From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: Doug Evans <dje@google.com>, gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [python][patch] Inferior and Thread information support.
Date: Fri, 25 Jun 2010 20:41:00 -0000 [thread overview]
Message-ID: <m3mxui4zhr.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4C1BD2B2.80503@redhat.com> (Phil Muldoon's message of "Fri, 18 Jun 2010 21:10:26 +0100")
>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
>> Arguably, gdb.Value should support the buffer protocol. I don't know if
>> that is directly possible, but if not we should supply a way to convert
>> a Value to a buffer -- to give the user a way to view the underlying
>> bits.
Phil> I don't disagree in principle. I'm not sure this is within the
Phil> the scope of this patch though?
What you have is fine.
Phil> From a pragmatic point of view, between you and Doug I'm a little lost
Phil> about what we need to do to get this patch suitable for inclusion in
Phil> the FSF tree, with a possible view for inclusion to 7.2? I'm not sure
Phil> what the removal of the max_count has to do with the other comments?
Phil> Making search_memory only support buffers is okay from the Python
Phil> side, that is easy. What else needs to be done is my question ;)
For the record, I think you are very close; fix the nits and I am
satisfied.
Tom
next prev parent reply other threads:[~2010-06-25 20:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-24 13:36 Phil Muldoon
2010-05-24 18:06 ` Eli Zaretskii
2010-06-10 18:40 ` Tom Tromey
2010-06-14 12:42 ` Phil Muldoon
2010-06-15 15:24 ` Pedro Alves
2010-06-15 18:11 ` Tom Tromey
2010-06-15 18:24 ` Pedro Alves
2010-06-15 19:58 ` Phil Muldoon
2010-06-15 20:36 ` Pedro Alves
2010-06-18 6:49 ` Phil Muldoon
2010-06-18 14:21 ` Doug Evans
2010-06-18 15:47 ` Phil Muldoon
2010-06-18 17:59 ` Tom Tromey
2010-06-18 20:10 ` Phil Muldoon
2010-06-25 20:41 ` Tom Tromey [this message]
2010-06-18 18:04 ` Tom Tromey
2010-06-22 10:32 ` Phil Muldoon
2010-06-25 20:38 ` Tom Tromey
2010-06-28 9:22 ` Phil Muldoon
2010-06-28 19:51 ` Tom Tromey
2010-06-28 21:35 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3mxui4zhr.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).