From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6783 invoked by alias); 25 Jun 2010 20:41:24 -0000 Received: (qmail 6772 invoked by uid 22791); 25 Jun 2010 20:41:24 -0000 X-SWARE-Spam-Status: No, hits=-5.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 Jun 2010 20:41:19 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5PKepfF021536 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 25 Jun 2010 16:40:51 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5PKeowS026360; Fri, 25 Jun 2010 16:40:51 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o5PKeoDu030855; Fri, 25 Jun 2010 16:40:50 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 05D273792DB; Fri, 25 Jun 2010 14:40:50 -0600 (MDT) From: Tom Tromey To: Phil Muldoon Cc: Doug Evans , gdb-patches ml Subject: Re: [python][patch] Inferior and Thread information support. References: <4BFA6E82.3070704@redhat.com> <4C1B16BF.3040000@redhat.com> <4C1B94F9.4010403@redhat.com> <4C1BD2B2.80503@redhat.com> Reply-To: tromey@redhat.com Date: Fri, 25 Jun 2010 20:41:00 -0000 In-Reply-To: <4C1BD2B2.80503@redhat.com> (Phil Muldoon's message of "Fri, 18 Jun 2010 21:10:26 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00596.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: >> Arguably, gdb.Value should support the buffer protocol. I don't know if >> that is directly possible, but if not we should supply a way to convert >> a Value to a buffer -- to give the user a way to view the underlying >> bits. Phil> I don't disagree in principle. I'm not sure this is within the Phil> the scope of this patch though? What you have is fine. Phil> From a pragmatic point of view, between you and Doug I'm a little lost Phil> about what we need to do to get this patch suitable for inclusion in Phil> the FSF tree, with a possible view for inclusion to 7.2? I'm not sure Phil> what the removal of the max_count has to do with the other comments? Phil> Making search_memory only support buffers is okay from the Python Phil> side, that is easy. What else needs to be done is my question ;) For the record, I think you are very close; fix the nits and I am satisfied. Tom