From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9848 invoked by alias); 11 Jan 2014 01:52:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9830 invoked by uid 89); 11 Jan 2014 01:52:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 11 Jan 2014 01:52:30 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0B1qQ3p028992 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 10 Jan 2014 20:52:26 -0500 Received: from psique (ovpn-113-176.phx2.redhat.com [10.3.113.176]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s0B1qNNo031364 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 10 Jan 2014 20:52:25 -0500 From: Sergio Durigan Junior To: Joel Brobecker Cc: GDB Patches , Mark Kettenis Subject: Re: [PATCH] Split i386_stap_parse_special_token into smaller functions References: <20131230031112.GC6055@adacore.com> X-URL: http://www.redhat.com Date: Sat, 11 Jan 2014 01:52:00 -0000 In-Reply-To: (Sergio Durigan Junior's message of "Mon, 06 Jan 2014 13:34:48 -0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00303.txt.bz2 On Monday, January 06 2014, I wrote: > On Monday, December 30 2014, Joel Brobecker wrote: > >>> As requested by Joel on: >>> >>> >>> >>> I am reposting this separate patch whose only purpose is to split >>> i386_stap_parse_special_token into smaller functions. I haven't >>> modified anything logical in the functions, i.e., there's still one >>> latent bug on i386_stap_parse_special_token_triplet now. I will soon >>> post a patch to fix this, and to also improve the readability of the two >>> new functions. >>> >>> I am also posting the output of "git diff -b" here. >> >> Thank you, Sergio. This patch is missing a ChangeLog :). >> >> FWIW, this patch looks good to me, and it is IMO a nice improvement >> over the current state. But i386-tdep.c is usually under Mark's >> responsibility, so let's give him a little bit of time to reply >> as well. > > Ping. Ping^2. This patch is pretty simple IMO (just code movement), so maybe it could be reviewed by some other maintainer and maybe approved? It's holding a fix for a bug :-). Thanks, -- Sergio