From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-77915-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29242 invoked by alias); 31 Jan 2011 15:05:52 -0000
Received: (qmail 29232 invoked by uid 22791); 31 Jan 2011 15:05:51 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 31 Jan 2011 15:05:47 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p0VF5NYJ023225	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 31 Jan 2011 10:05:23 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p0VF5MEW026704;	Mon, 31 Jan 2011 10:05:22 -0500
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p0VF5LuU029637;	Mon, 31 Jan 2011 10:05:22 -0500
Received: by opsy.redhat.com (Postfix, from userid 500)	id C732E3782CA; Mon, 31 Jan 2011 08:05:21 -0700 (MST)
From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: FYI: add user_breakpoint_p
References: <m362t9lpix.fsf@fleche.redhat.com>	<20110131020543.GB2384@adacore.com>
Date: Mon, 31 Jan 2011 15:11:00 -0000
In-Reply-To: <20110131020543.GB2384@adacore.com> (Joel Brobecker's message of	"Mon, 31 Jan 2011 06:05:43 +0400")
Message-ID: <m3oc6xxgem.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-01/txt/msg00583.txt.bz2

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> Just one question about style:

>> -    if (!user_settable_breakpoint (tp) || tp->number < 0)
>> +    if (! user_breakpoint_p (tp))

Joel> Do we agree on whether to write this as the above, or whether we should
Joel> not have a space between the '!' and the expression being negated:

I have trouble remembering whether we have a rule here.
I will remove the space.  It doesn't matter to me either way if we have
it or not.

Tom