* [PATCH] Fix order of inferiors in "thread apply all"
@ 2016-08-30 14:36 Andreas Arnez
2016-08-30 14:44 ` Pedro Alves
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Arnez @ 2016-08-30 14:36 UTC (permalink / raw)
To: gdb-patches; +Cc: Philipp Rudo
This inserts missing parentheses in the calculation of the comparison
result between two different inferior numbers. The problem was found by
Philipp Rudo.
gdb/ChangeLog:
* thread.c (tp_array_compar): Insert missing parentheses.
gdb/testsuite/ChangeLog:
* gdb.multi/tids.exp: Test "thread apply all".
---
gdb/testsuite/gdb.multi/tids.exp | 6 ++++++
gdb/thread.c | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.multi/tids.exp b/gdb/testsuite/gdb.multi/tids.exp
index 5d8701e..12ce98a 100644
--- a/gdb/testsuite/gdb.multi/tids.exp
+++ b/gdb/testsuite/gdb.multi/tids.exp
@@ -224,6 +224,12 @@ with_test_prefix "two inferiors" {
thr_apply_info_thr "1.1-2 2.2-3" \
"1.1 1.2 2.2 2.3"
+ # All threads.
+ thread_apply "all" \
+ "2.3 2.2 2.1 1.3 1.2 1.1"
+ thread_apply "all -ascending" \
+ "1.1 1.2 1.3 2.1 2.2 2.3"
+
# Now test using GDB convenience variables.
gdb_test "p \$inf = 1" " = 1"
diff --git a/gdb/thread.c b/gdb/thread.c
index ab98777..a66a2b5 100644
--- a/gdb/thread.c
+++ b/gdb/thread.c
@@ -1725,7 +1725,7 @@ tp_array_compar (const void *ap_voidp, const void *bp_voidp)
if (a->inf->num != b->inf->num)
{
- return ((a->inf->num > b->inf->num) - (a->inf->num < b->inf->num)
+ return (((a->inf->num > b->inf->num) - (a->inf->num < b->inf->num))
* (tp_array_compar_ascending ? +1 : -1));
}
--
2.5.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix order of inferiors in "thread apply all"
2016-08-30 14:36 [PATCH] Fix order of inferiors in "thread apply all" Andreas Arnez
@ 2016-08-30 14:44 ` Pedro Alves
2016-08-30 15:09 ` Andreas Arnez
0 siblings, 1 reply; 5+ messages in thread
From: Pedro Alves @ 2016-08-30 14:44 UTC (permalink / raw)
To: Andreas Arnez, gdb-patches; +Cc: Philipp Rudo
On 08/30/2016 03:36 PM, Andreas Arnez wrote:
> This inserts missing parentheses in the calculation of the comparison
> result between two different inferior numbers. The problem was found by
> Philipp Rudo.
Whoops.
>
> gdb/ChangeLog:
>
> * thread.c (tp_array_compar): Insert missing parentheses.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.multi/tids.exp: Test "thread apply all".
OK.
Thanks,
Pedro Alves
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix order of inferiors in "thread apply all"
2016-08-30 14:44 ` Pedro Alves
@ 2016-08-30 15:09 ` Andreas Arnez
0 siblings, 0 replies; 5+ messages in thread
From: Andreas Arnez @ 2016-08-30 15:09 UTC (permalink / raw)
To: Pedro Alves; +Cc: gdb-patches, Philipp Rudo
On Tue, Aug 30 2016, Pedro Alves wrote:
> On 08/30/2016 03:36 PM, Andreas Arnez wrote:
>> This inserts missing parentheses in the calculation of the comparison
>> result between two different inferior numbers. The problem was found by
>> Philipp Rudo.
>
> Whoops.
>
>>
>> gdb/ChangeLog:
>>
>> * thread.c (tp_array_compar): Insert missing parentheses.
>>
>> gdb/testsuite/ChangeLog:
>>
>> * gdb.multi/tids.exp: Test "thread apply all".
>
> OK.
Thanks, pushed.
--
Andreas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix order of inferiors in "thread apply all"
2016-09-15 11:54 ` [PATCH] Fix order of inferiors in "thread apply all" Andreas Arnez
@ 2016-09-15 12:03 ` Andreas Arnez
0 siblings, 0 replies; 5+ messages in thread
From: Andreas Arnez @ 2016-09-15 12:03 UTC (permalink / raw)
To: gdb-patches
On Thu, Sep 15 2016, Andreas Arnez wrote:
> This inserts missing parentheses in the calculation of the comparison
> result between two different inferior numbers. The problem was found by
> Philipp Rudo.
Oops, this is an inadvertant re-send. Please ignore.
--
Andreas
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] Fix order of inferiors in "thread apply all"
2016-09-15 11:53 [PATCH 0/6] S390: Watchpoint enhancements and hardware breakpoints Andreas Arnez
@ 2016-09-15 11:54 ` Andreas Arnez
2016-09-15 12:03 ` Andreas Arnez
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Arnez @ 2016-09-15 11:54 UTC (permalink / raw)
To: gdb-patches
This inserts missing parentheses in the calculation of the comparison
result between two different inferior numbers. The problem was found by
Philipp Rudo.
gdb/ChangeLog:
* thread.c (tp_array_compar): Insert missing parentheses.
gdb/testsuite/ChangeLog:
* gdb.multi/tids.exp: Test "thread apply all".
---
gdb/testsuite/gdb.multi/tids.exp | 6 ++++++
gdb/thread.c | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.multi/tids.exp b/gdb/testsuite/gdb.multi/tids.exp
index 5d8701e..12ce98a 100644
--- a/gdb/testsuite/gdb.multi/tids.exp
+++ b/gdb/testsuite/gdb.multi/tids.exp
@@ -224,6 +224,12 @@ with_test_prefix "two inferiors" {
thr_apply_info_thr "1.1-2 2.2-3" \
"1.1 1.2 2.2 2.3"
+ # All threads.
+ thread_apply "all" \
+ "2.3 2.2 2.1 1.3 1.2 1.1"
+ thread_apply "all -ascending" \
+ "1.1 1.2 1.3 2.1 2.2 2.3"
+
# Now test using GDB convenience variables.
gdb_test "p \$inf = 1" " = 1"
diff --git a/gdb/thread.c b/gdb/thread.c
index ab98777..a66a2b5 100644
--- a/gdb/thread.c
+++ b/gdb/thread.c
@@ -1725,7 +1725,7 @@ tp_array_compar (const void *ap_voidp, const void *bp_voidp)
if (a->inf->num != b->inf->num)
{
- return ((a->inf->num > b->inf->num) - (a->inf->num < b->inf->num)
+ return (((a->inf->num > b->inf->num) - (a->inf->num < b->inf->num))
* (tp_array_compar_ascending ? +1 : -1));
}
--
2.5.0
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-09-15 12:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-30 14:36 [PATCH] Fix order of inferiors in "thread apply all" Andreas Arnez
2016-08-30 14:44 ` Pedro Alves
2016-08-30 15:09 ` Andreas Arnez
2016-09-15 11:53 [PATCH 0/6] S390: Watchpoint enhancements and hardware breakpoints Andreas Arnez
2016-09-15 11:54 ` [PATCH] Fix order of inferiors in "thread apply all" Andreas Arnez
2016-09-15 12:03 ` Andreas Arnez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).