From: Tom Tromey <tromey@redhat.com>
To: sami wagiaalla <swagiaal@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 2/3] Change cplus_specific to an alocated struct
Date: Tue, 13 Jul 2010 17:24:00 -0000 [thread overview]
Message-ID: <m3pqyrthve.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4C3B598F.9000403@redhat.com> (sami wagiaalla's message of "Mon, 12 Jul 2010 14:06:07 -0400")
>>>>> "Sami" == sami wagiaalla <swagiaal@redhat.com> writes:
Sami> This patch creates setters and getters for the newly named
Sami> mangled_lang struct and changes all references to use these functions.
Sami> +extern void
Sami> +symbol_set_demangled_name (struct general_symbol_info *gsymbol, char *name);
In a declaration, we generally don't put a newline after the type.
You can break the line after a "," instead.
Sami> +extern char*
Space before the "*", as well as the line break thing.
This is ok with those changes. Thanks.
I was planning to ask for the new functions to be const-correct, but I
think that would be a big change, since things like symbol_natural_name
return a plain "char *" :-(
Tom
next prev parent reply other threads:[~2010-07-13 17:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 16:05 [patch] " sami wagiaalla
2010-05-26 16:55 ` sami wagiaalla
2010-06-08 17:02 ` Tom Tromey
2010-06-14 19:29 ` sami wagiaalla
2010-06-15 22:56 ` Tom Tromey
2010-07-12 18:03 ` [patch 1/3] " sami wagiaalla
2010-07-13 17:16 ` Tom Tromey
2010-07-16 14:15 ` sami wagiaalla
2010-07-16 15:24 ` Tom Tromey
2010-07-12 18:06 ` [patch 2/3] " sami wagiaalla
2010-07-13 17:24 ` Tom Tromey [this message]
2010-07-16 14:15 ` sami wagiaalla
2010-07-12 18:08 ` [patch 3/3] " sami wagiaalla
2010-07-13 17:38 ` Tom Tromey
2010-07-16 14:15 ` sami wagiaalla
2010-07-16 15:29 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3pqyrthve.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=swagiaal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).