From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3289 invoked by alias); 13 Jul 2010 17:24:29 -0000 Received: (qmail 3281 invoked by uid 22791); 13 Jul 2010 17:24:28 -0000 X-SWARE-Spam-Status: No, hits=-6.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Jul 2010 17:24:24 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6DHONZN019221 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 13 Jul 2010 13:24:23 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o6DHOMWc027376; Tue, 13 Jul 2010 13:24:23 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o6DHOLth027222; Tue, 13 Jul 2010 13:24:22 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 8DC933782A3; Tue, 13 Jul 2010 11:24:21 -0600 (MDT) From: Tom Tromey To: sami wagiaalla Cc: gdb-patches@sourceware.org Subject: Re: [patch 2/3] Change cplus_specific to an alocated struct References: <4BFD4230.3030600@redhat.com> <4C167FCA.7030300@redhat.com> <4C3B598F.9000403@redhat.com> Date: Tue, 13 Jul 2010 17:24:00 -0000 In-Reply-To: <4C3B598F.9000403@redhat.com> (sami wagiaalla's message of "Mon, 12 Jul 2010 14:06:07 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00223.txt.bz2 >>>>> "Sami" == sami wagiaalla writes: Sami> This patch creates setters and getters for the newly named Sami> mangled_lang struct and changes all references to use these functions. Sami> +extern void Sami> +symbol_set_demangled_name (struct general_symbol_info *gsymbol, char *name); In a declaration, we generally don't put a newline after the type. You can break the line after a "," instead. Sami> +extern char* Space before the "*", as well as the line break thing. This is ok with those changes. Thanks. I was planning to ask for the new functions to be const-correct, but I think that would be a big change, since things like symbol_natural_name return a plain "char *" :-( Tom