From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44933 invoked by alias); 1 Mar 2015 21:04:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44914 invoked by uid 89); 1 Mar 2015 21:04:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,KAM_FROM_URIBL_PCCC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-pa0-f51.google.com Received: from mail-pa0-f51.google.com (HELO mail-pa0-f51.google.com) (209.85.220.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 01 Mar 2015 21:04:46 +0000 Received: by pablf10 with SMTP id lf10so37803644pab.6 for ; Sun, 01 Mar 2015 13:04:45 -0800 (PST) X-Received: by 10.70.37.41 with SMTP id v9mr42126107pdj.6.1425243885306; Sun, 01 Mar 2015 13:04:45 -0800 (PST) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by mx.google.com with ESMTPSA id zc3sm7293323pbb.46.2015.03.01.13.04.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Mar 2015 13:04:44 -0800 (PST) From: Doug Evans To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 6/9] Explicit locations: introduce explicit locations References: <20150217220619.1312.39861.stgit@valrhona.uglyboxes.com> <20150217220651.1312.45847.stgit@valrhona.uglyboxes.com> Date: Sun, 01 Mar 2015 21:04:00 -0000 In-Reply-To: <20150217220651.1312.45847.stgit@valrhona.uglyboxes.com> (Keith Seitz's message of "Tue, 17 Feb 2015 14:06:51 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00008.txt.bz2 Keith Seitz writes: > This patch add support for explicit locations and switches many linespec > locations to this new location type. This patch also converts all > linespec locations entered by the user to an explicit representation > internally (thus bypassing the linespec parser when resetting the > breakpoint). > > This patch does not introduce any user-visible changes. > > > gdb/ChangeLog: > > * break-catch-throw.c (re_set_exception_catchpoint): Convert > linespec into explicit location. > * breakpoint.c (create_overlay_breakpoint): Likewise. > (create_longjmp_master_breakpoint): Likewise. > (create_std_terminate_master_breakpoint): Likewise. > (create_exception_master_breakpoint): Likewise. > (create_breakpoint): For pending explicit locations, append extra_string > to the canonical representation. > (update_static_tracepoint): Convert linespec into explicit location. > (location_to_sals): Save the string representation of the location > for pending locations which were resolved. > * linespec.c (enum offset_relative_sign): Move to location.h. > (struct line_offset): Likewise. > (struct linespec) > : Replace with ... > : ... this. > : New member. > (PARSER_EXPLICIT): New accessor macro. > (undefined_label_error): New function. > (source_file_not_found_error): New function. > (linespec_parse_basic): The parser result is now an explicit location. > Use PARSER_EXPLICIT to access it. > Use undefined_label_error. > (canonicalize_linespec): Convert canonical linespec into explicit > location. > Move string representation of location to explicit_location_to_linespec > and use it and explicit_location_to_string to save string > representations of the canonical location. > (create_sals_line_offset): `ls' contains an explicit location. > Update all references. > (convert_linespec_to_sals): Likewise. > (convert_explicit_location_to_sals): New function. > (parse_linespec): Use PARSER_EXPLICIT to access the parser > result's explicit location. > (linespec_state_constructor): Initialize is_linespec. > Use PARSER_EXPLICIT. > (linespec_parser_delete): Use PARSER_EXPLICIT to access the parser's > result. > (event_location_to_sals): For linespec locations, set is_linespec. > Handle explicit locations. > (decode_objc): 'ls' contains an explicit location now. Update all > references. > (symtabs_from_filename): Use source_file_not_found_error. > * location.c (struct event_location.u) : New member. > (initialize_explicit_location): New function. > (initialize_event_location): Initialize explicit locations. > (new_explicit_location, get_explicit_location) > (get_explicit_location_const): New functions. > (explicit_to_string_internal): New function; most of contents moved > from canonicalize_linespec. > (explicit_location_to_string): New function. > (explicit_location_to_linespec): New function. > (copy_event_location): Handle explicit locations. > (delete_event_location): Likewise. > (event_location_to_string_const): Likewise. > (event_location_empty_p): Likewise. > * location.h (enum offset_relative_sign): Move here from linespec.h. > (struct line_offset): Likewise. > (enum event_location_type): Add EXPLICIT_LOCATION. > (struct explicit_location): New structure. > (explicit_location_to_string): Declare. > (explicit_location_to_linespec): Declare. > (new_explicit_location, get_explicit_locationp > (get_explicit_location_const, initialize_explicit_location): Declare. LGTM