From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21487 invoked by alias); 30 Jul 2010 20:46:23 -0000 Received: (qmail 21478 invoked by uid 22791); 30 Jul 2010 20:46:23 -0000 X-SWARE-Spam-Status: No, hits=-5.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,TW_JC,TW_YM,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 30 Jul 2010 20:46:17 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6UKkGkP027136 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 30 Jul 2010 16:46:16 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o6UKkFYX009477; Fri, 30 Jul 2010 16:46:16 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o6UKkFX2018493; Fri, 30 Jul 2010 16:46:15 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id BA9053792BD; Fri, 30 Jul 2010 14:46:14 -0600 (MDT) From: Tom Tromey To: gdb-patches@sourceware.org Subject: Re: [0/4] RFC: add DWARF index support References: Date: Fri, 30 Jul 2010 20:46:00 -0000 In-Reply-To: (Tom Tromey's message of "Fri, 09 Jul 2010 11:31:04 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00592.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Tom> Roland suggested we wrap up the index-creation code into a helper Tom> script. Tom> I'm not sure if this is something people would want in gdb proper, but I Tom> figured I would send it here just in case. I am going to check this in. I'm actually committing the appended. I addressed Eli's comments, and I added ".sh" to the name of the file as it appears in the source tree. Tom 2010-07-30 Tom Tromey * Makefile.in (install-only): Install gdb-add-index. * gdb-add-index.sh: New file. 2010-07-30 Tom Tromey * gdb.texinfo (Index Files): Mention gdb-add-index. Index: Makefile.in =================================================================== RCS file: /cvs/src/src/gdb/Makefile.in,v retrieving revision 1.1128 diff -u -r1.1128 Makefile.in --- Makefile.in 28 Jul 2010 18:32:33 -0000 1.1128 +++ Makefile.in 30 Jul 2010 20:45:30 -0000 @@ -1018,7 +1018,16 @@ $(SHELL) $(srcdir)/../mkinstalldirs \ $(DESTDIR)$(man1dir) ; \ $(INSTALL_DATA) $(srcdir)/gdb.1 \ - $(DESTDIR)$(man1dir)/$$transformed_name.1 + $(DESTDIR)$(man1dir)/$$transformed_name.1; \ + transformed_name=`t='$(program_transform_name)'; \ + echo gdb-add-index | sed -e "$$t"` ; \ + if test "x$$transformed_name" = x; then \ + transformed_name=gdb-add-index ; \ + else \ + true ; \ + fi ; \ + $(INSTALL_PROGRAM) $(srcdir)/gdb-add-index.sh \ + $(DESTDIR)$(bindir)/$$transformed_name$(EXEEXT) @$(MAKE) DO=install "DODIRS=$(SUBDIRS)" $(FLAGS_TO_PASS) subdir_do .PHONY: install-tui install-tui: Index: gdb-add-index.sh =================================================================== RCS file: gdb-add-index.sh diff -N gdb-add-index.sh --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ gdb-add-index.sh 30 Jul 2010 20:45:30 -0000 @@ -0,0 +1,29 @@ +#! /bin/sh + +# Add a .gdb_index section to a file. + +# Copyright (C) 2010 Free Software Foundation, Inc. +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +file="$1" +dir="${file%/*}" + +gdb --batch-silent -ex "file $file" -ex "save gdb-index $dir" + +if test -f "${file}.gdb-index"; then + objcopy --add-section .gdb_index="${file}.gdb-index" --set-section-flags .gdb_index=readonly "$file" "$file" + rm -f "${file}.gdb-index" +fi + +exit 0 Index: doc/gdb.texinfo =================================================================== RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v retrieving revision 1.745 diff -u -r1.745 gdb.texinfo --- doc/gdb.texinfo 30 Jul 2010 14:32:02 -0000 1.745 +++ doc/gdb.texinfo 30 Jul 2010 20:45:34 -0000 @@ -15244,6 +15244,15 @@ for DWARF debugging information, not stabs. And, they do not currently work for programs using Ada. +@pindex gdb-add-index +@value{GDBN} comes with a program, @command{gdb-add-index}, which can +be used to add the index to a symbol file. It takes the symbol file +as its only argument: + +@smallexample +$ gdb-add-index symfile +@end smallexample + @node Symbol Errors @section Errors Reading Symbol Files