* [PATCH] S390: Fix output path for s390-multiarch test case
@ 2016-03-15 15:39 Andreas Arnez
2016-03-17 10:06 ` [PUSHED][PATCH] " Andreas Arnez
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Arnez @ 2016-03-15 15:39 UTC (permalink / raw)
To: gdb-patches; +Cc: Ulrich Weigand
Since test artifacts are organized in a directory hierarchy, the
s390-multiarch test case is not executed correctly any more. This is
because it uses an obsolete way of constructing the output paths.
This fix invokes standard_testfile instead.
gdb/testsuite/ChangeLog:
* gdb.arch/s390-multiarch.exp: Use standard_testfile instead of
maintaining separate logic for constructing the output path.
---
gdb/testsuite/gdb.arch/s390-multiarch.exp | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/gdb/testsuite/gdb.arch/s390-multiarch.exp b/gdb/testsuite/gdb.arch/s390-multiarch.exp
index 00b3589..3bed279 100644
--- a/gdb/testsuite/gdb.arch/s390-multiarch.exp
+++ b/gdb/testsuite/gdb.arch/s390-multiarch.exp
@@ -28,9 +28,8 @@ if { ![isnative] || ![istarget s390x-*-* ] } {
return
}
-set testfile "s390-multiarch"
-set srcfile "${srcdir}/${subdir}/${testfile}.c"
-set binprefix "${objdir}/${subdir}/${testfile}"
+standard_testfile
+set binprefix $binfile
gdb_exit
@@ -39,13 +38,13 @@ if { [get_compiler_info] } {
}
proc compile_and_dump {variant ccopts binfile} {
- global srcfile
+ global srcdir subdir srcfile
set compile_flags {debug}
foreach opt $ccopts {
lappend compile_flags "additional_flags=$opt"
}
set test "compile ($variant)"
- if { [gdb_compile $srcfile $binfile executable $compile_flags] != "" } {
+ if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "$binfile" executable $compile_flags] != "" } {
fail $test
return {}
}
--
2.3.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PUSHED][PATCH] S390: Fix output path for s390-multiarch test case
2016-03-15 15:39 [PATCH] S390: Fix output path for s390-multiarch test case Andreas Arnez
@ 2016-03-17 10:06 ` Andreas Arnez
0 siblings, 0 replies; 2+ messages in thread
From: Andreas Arnez @ 2016-03-17 10:06 UTC (permalink / raw)
To: gdb-patches; +Cc: Ulrich Weigand
On Tue, Mar 15 2016, Andreas Arnez wrote:
> Since test artifacts are organized in a directory hierarchy, the
> s390-multiarch test case is not executed correctly any more. This is
> because it uses an obsolete way of constructing the output paths.
>
> This fix invokes standard_testfile instead.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.arch/s390-multiarch.exp: Use standard_testfile instead of
> maintaining separate logic for constructing the output path.
Pushed.
--
Andreas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-17 10:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-15 15:39 [PATCH] S390: Fix output path for s390-multiarch test case Andreas Arnez
2016-03-17 10:06 ` [PUSHED][PATCH] " Andreas Arnez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).