Re: [PATCH v3 01/19] Add struct completer_data to the completion API.

[Doug Evans <xdje42@gmail.com>]

Keith Seitz <keiths@redhat.com> writes:
> Differences in this revision:
>
> 1. Updated new completer[-related] functions reg_or_group_completer_1,
>    reg_or_group_completer, layout_completer, tui_reggroup_completer,
>    window_name_completer, focus_completer, and winheight_completer.
>
> ---
>
> This patch is largely mechanical.  It modifies the completion API so
> that all completion functions take a new (pointer to a) structure,
> which will (eventually) be used internally by the completer to perform
> completion limiting.
>
> gdb/ChangeLog
>
> 	* completer.c (struct completer_data): Define.
> 	* language.h (struct language_defn)
> 	<la_make_symbol_completion_list>: Add struct completer_data
> 	to argument list.
> 	All users updated.
> 	* symtab.c (COMPLETION_LIST_ADD_SYMBOL): Add CDATA argument.
> 	Update all callers.
> 	(MCOMPLETION_LIST_ADD_SYMBOL): Likewise.
> 	(struct add_name_data) <completer_data>: New field.
> 	(default_make_symbol_completion_list_break_on_1): Initialize
> 	the above new field.
> 	(struct add_partial_filename_data) <completer_data>: New field.
> 	(make_source_files_completion_list): Initialize the above new
> 	field.

LGTM.