From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8097 invoked by alias); 18 May 2015 07:16:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8079 invoked by uid 89); 18 May 2015 07:16:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f43.google.com Received: from mail-pa0-f43.google.com (HELO mail-pa0-f43.google.com) (209.85.220.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 18 May 2015 07:16:43 +0000 Received: by padbw4 with SMTP id bw4so139990212pad.0 for ; Mon, 18 May 2015 00:16:41 -0700 (PDT) X-Received: by 10.70.119.36 with SMTP id kr4mr42469197pdb.39.1431933401846; Mon, 18 May 2015 00:16:41 -0700 (PDT) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by mx.google.com with ESMTPSA id bi4sm1156391pbc.56.2015.05.18.00.16.40 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 May 2015 00:16:41 -0700 (PDT) From: Doug Evans To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v4 8/9] Explicit locations: MI support for explicit locations References: <20150507180523.19629.77846.stgit@valrhona.uglyboxes.com> <20150507180605.19629.58159.stgit@valrhona.uglyboxes.com> Date: Mon, 18 May 2015 07:16:00 -0000 In-Reply-To: <20150507180605.19629.58159.stgit@valrhona.uglyboxes.com> (Keith Seitz's message of "Thu, 07 May 2015 11:06:05 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00456.txt.bz2 Keith Seitz writes: > This patch adds support for explicit locations to MI's -break-insert > command. The new options, documented in the User Manual, are > --source, --line, --function, and --label. > > gdb/ChangeLog: > > * mi/mi-cmd-break.c (mi_cmd_break_insert_1): Add support for > explicit locations, options "--source", "--function", > "--label", and "--line". > > gdb/testsuite/ChangeLog: > > * gdb.mi/mi-break.exp (test_explicit_breakpoints): New proc. > (at toplevel): Call test_explicit_breakpoints. > * gdb.mi/mi-dprintf.exp: Add tests for explicit dprintf > breakpoints. > * lib/mi-support.exp (mi_make_breakpoint): Add support for > breakpoint conditions, "-cond". LGTM