From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 1/2] do not use python<version> subdir when including Python .h file
Date: Fri, 28 Jan 2011 14:54:00 -0000 [thread overview]
Message-ID: <m3sjwdf62l.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20110128140947.GB2467@adacore.com> (Joel Brobecker's message of "Fri, 28 Jan 2011 18:09:47 +0400")
Tom> How does this work when srcdir != builddir? In that case isn't our
Tom> python.h found only via a -I option? Thus causing a clash?
Joel> I discovered while working on this that there is actually no -I option
Joel> for the gdb/python directory (I thought that we did and I was looking
Joel> at that in an attempt to eliminate it). Files from the gdb/ directory
Joel> include our python headers using #include "python/python-internal.h",
Joel> while files in the gdb/python/ directory include them more directly
Joel> using #include "python-internal.h".
Aha, that's what I was forgetting.
Thanks.
Tom
next prev parent reply other threads:[~2011-01-28 14:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-22 23:45 Allow building GDB with Python support on Windows/MinGW Joel Brobecker
2011-01-22 23:45 ` [RFA 2/2] allow building GDB with Python support on MinGW Joel Brobecker
2011-01-28 11:32 ` Tom Tromey
2011-01-31 4:50 ` Joel Brobecker
2011-01-23 0:14 ` [RFA 1/2] do not use python<version> subdir when including Python .h file Joel Brobecker
2011-01-28 11:24 ` Tom Tromey
2011-01-28 14:37 ` Joel Brobecker
2011-01-28 14:54 ` Tom Tromey [this message]
2011-01-31 4:44 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3sjwdf62l.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).