From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [python][patch] Inferior and Thread information support.
Date: Fri, 18 Jun 2010 18:04:00 -0000 [thread overview]
Message-ID: <m3sk4kmd3c.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4C1B16BF.3040000@redhat.com> (Phil Muldoon's message of "Fri, 18 Jun 2010 07:48:31 +0100")
>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
Phil> +int
Phil> +search_memory (CORE_ADDR *start_addr, ULONGEST *search_space_len,
Phil> + const char *pattern_buf, ULONGEST pattern_len,
Phil> + CORE_ADDR *found_addr)
I think if you remove the max_count parameter then you won't need this
at all, you can just call target_search_memory directly.
Phil> +struct inflist_entry {
Phil> + inferior_object *inf_obj;
Phil> + struct inflist_entry *next;
Phil> +};
[...]
Phil> +/* List containing inferior_objects. This list owns a reference to each
Phil> + object it contains. */
Phil> +static struct inflist_entry *gdbpy_inferior_list;
Phil> +
Phil> +static int ninferiors;
I'm sorry I missed this earlier...
struct inferior now has a "user-data" API, like objfiles do.
See register_inferior_data and register_inferior_data_with_cleanup.
I think this means that we can attach the Python objects directly to the
struct inferior, rather than keeping an external list.
This change should simplify a lot of code.
Tom
next prev parent reply other threads:[~2010-06-18 18:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-24 13:36 Phil Muldoon
2010-05-24 18:06 ` Eli Zaretskii
2010-06-10 18:40 ` Tom Tromey
2010-06-14 12:42 ` Phil Muldoon
2010-06-15 15:24 ` Pedro Alves
2010-06-15 18:11 ` Tom Tromey
2010-06-15 18:24 ` Pedro Alves
2010-06-15 19:58 ` Phil Muldoon
2010-06-15 20:36 ` Pedro Alves
2010-06-18 6:49 ` Phil Muldoon
2010-06-18 14:21 ` Doug Evans
2010-06-18 15:47 ` Phil Muldoon
2010-06-18 17:59 ` Tom Tromey
2010-06-18 20:10 ` Phil Muldoon
2010-06-25 20:41 ` Tom Tromey
2010-06-18 18:04 ` Tom Tromey [this message]
2010-06-22 10:32 ` Phil Muldoon
2010-06-25 20:38 ` Tom Tromey
2010-06-28 9:22 ` Phil Muldoon
2010-06-28 19:51 ` Tom Tromey
2010-06-28 21:35 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3sk4kmd3c.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).