From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: <gdb-patches@sourceware.org>, "'Eli Zaretskii'" <eliz@gnu.org>
Subject: Re: [PING] [RFA-v3] Allow explicit 16 or 32 char in 'x /s'
Date: Wed, 21 Apr 2010 22:49:00 -0000 [thread overview]
Message-ID: <m3sk6o8lqr.fsf@fleche.redhat.com> (raw)
In-Reply-To: <48335.255837492$1271407316@news.gmane.org> (Pierre Muller's message of "Fri, 16 Apr 2010 10:41:21 +0200")
>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:
Pierre> Tom,
Pierre> would you have some time to
Pierre> take again a look at this?
This looks pretty good. A couple nits and it is ok.
>> + /* Multi-byte character types. */
I think it is more clear to describe these as "wide" character types.
I have usually seen "multi-byte" used synonymously with "variable length".
This comment appears twice.
>> + The case of strings is handled n decode_format, only explicit
Typo, s/n/in/
Ok with those changes. Thanks.
Tom
next prev parent reply other threads:[~2010-04-21 22:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <11484.4708740295$1268865815@news.gmane.org>
2010-03-18 22:08 ` [RFC] " Tom Tromey
2010-03-19 7:32 ` Eli Zaretskii
2010-03-22 22:54 ` Pierre Muller
[not found] ` <15103.6087111153$1269298497@news.gmane.org>
2010-03-30 20:33 ` Tom Tromey
2010-03-31 16:11 ` [RFC-v2] " Pierre Muller
[not found] ` <006101cad0ec$cb7915d0$626b4170$%muller@ics-cnrs.unistra.fr>
2010-03-31 16:17 ` Eli Zaretskii
2010-04-01 9:34 ` Pierre Muller
[not found] ` <000f01cad17e$7686f140$6394d3c0$%muller@ics-cnrs.unistra.fr>
2010-04-01 13:17 ` Eli Zaretskii
2010-04-05 23:01 ` Pierre Muller
[not found] ` <002701cad513$e44a7420$acdf5c60$%muller@ics-cnrs.unistra.fr>
2010-04-06 17:51 ` Eli Zaretskii
2010-04-08 20:58 ` [RFA-v3] " Pierre Muller
2010-04-16 8:41 ` [PING] " Pierre Muller
[not found] ` <48335.255837492$1271407316@news.gmane.org>
2010-04-21 22:49 ` Tom Tromey [this message]
2010-04-21 23:22 ` Pierre Muller
2010-06-11 17:38 ` Ulrich Weigand
2010-07-02 19:09 ` Tom Tromey
2010-07-05 10:17 ` Ulrich Weigand
2010-07-20 20:13 ` [patch] testsuite: regression on failed charset.exp compilation [Re: [RFA-v3] Allow explicit 16 or 32 char in 'x /s'] Jan Kratochvil
2010-07-20 22:00 ` Tom Tromey
2010-07-20 22:13 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3sk6o8lqr.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).