From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-72396-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23439 invoked by alias); 21 Apr 2010 22:49:34 -0000
Received: (qmail 23395 invoked by uid 22791); 21 Apr 2010 22:49:33 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 	tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Apr 2010 22:49:25 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3LMnI5P023590 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); 	Wed, 21 Apr 2010 18:49:19 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3LMnHHK019487; 	Wed, 21 Apr 2010 18:49:18 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o3LMnGIa026863; 	Wed, 21 Apr 2010 18:49:17 -0400
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 4A8AB37817D; Wed, 21 Apr 2010 16:49:16 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: <gdb-patches@sourceware.org>, "'Eli Zaretskii'" <eliz@gnu.org>
Subject: Re: [PING] [RFA-v3] Allow explicit 16 or 32 char in 'x /s'
References: <11484.4708740295$1268865815@news.gmane.org> 	<m3mxy5z3j8.fsf@fleche.redhat.com> <83r5ngix6d.fsf@gnu.org> 	<15103.6087111153$1269298497@news.gmane.org> 	<m3r5n1v9c0.fsf@fleche.redhat.com> 	<006101cad0ec$cb7915d0$626b4170$%muller@ics-cnrs.unistra.fr> 	<83tyrwxy72.fsf@gnu.org> 	<000f01cad17e$7686f140$6394d3c0$%muller@ics-cnrs.unistra.fr> 	<83aatnxqhm.fsf@gnu.org> 	<002701cad513$e44a7420$acdf5c60$%muller@ics-cnrs.unistra.fr> 	<83fx38xydz.fsf@gnu.org> 	<001201cad75e$2ef3fcc0$8cdbf640$@muller@ics-cnrs.unistra.fr> 	<48335.255837492$1271407316@news.gmane.org>
Reply-To: tromey@redhat.com
Date: Wed, 21 Apr 2010 22:49:00 -0000
In-Reply-To: <48335.255837492$1271407316@news.gmane.org> (Pierre Muller's 	message of "Fri, 16 Apr 2010 10:41:21 +0200")
Message-ID: <m3sk6o8lqr.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00715.txt.bz2

>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:

Pierre>   Tom,
Pierre> would you have some time to 
Pierre> take again a look at this?

This looks pretty good.  A couple nits and it is ok.

>> +  /* Multi-byte character types.  */

I think it is more clear to describe these as "wide" character types.
I have usually seen "multi-byte" used synonymously with "variable length".

This comment appears twice.

>> +     The case of strings is handled n decode_format, only explicit

Typo, s/n/in/

Ok with those changes.  Thanks.

Tom