Re: [PATCH] Fix parallel testing issues in gdb.guile tests

[Doug Evans <xdje42@gmail.com>]

Yao Qi <yao@codesourcery.com> writes:

> Some gdb.guile tests such as scm-error.exp copies .scm file to
> ${subdir}/, how ${subdir} doesn't exist in parallel testing
> (outputs/${subdir} exists).
>
> $ make -j3 check TESTS='gdb.guile/scm-section-script.exp gdb.guile/scm-error.exp gdb.guile/scm-frame-args.exp'
>
> ERROR: remote_download to host of ../../../../git/gdb/testsuite/gdb.guile/scm-section-script.scm to gdb.guile/t-scm-section-script.scm: cp: cannot create regular file 'gdb.guile/t-scm-section-script.scm': No such file or directory
> ERROR: remote_download to host of ../../../../git/gdb/testsuite/gdb.guile/scm-frame-args.scm to gdb.guile/t-scm-frame-args.scm: cp: cannot create regular file
> 'gdb.guile/t-scm-frame-args.scm': No such file or directory
> ERROR: remote_download to host of ../../../../git/gdb/testsuite/gdb.guile/scm-error-1.scm to gdb.guile/t-scm-error-1.scm: cp: cannot create regular file 'gdb.guile/t-scm-error-1.scm': No such file or directory

Hmmm, there's something more going on here that we need to understand.
[The patch may still be ok, but I'd still like to understand
this error.]

I don't see these fails.
The files are going into $obj/gdb/testsuite/gdb.guile,
which does exist.
They *should* go in $obj/gdb/testsuite/outputs/foo, sure.
But how come you're getting this error?

> [...]
> diff --git a/gdb/testsuite/gdb.guile/scm-section-script.exp b/gdb/testsuite/gdb.guile/scm-section-script.exp
> index 0c5e489..a1ebd10 100644
> --- a/gdb/testsuite/gdb.guile/scm-section-script.exp
> +++ b/gdb/testsuite/gdb.guile/scm-section-script.exp
> @@ -35,14 +35,11 @@ standard_testfile
>  
>  # Make this available to gdb before the program starts, it is
>  # automagically loaded by gdb.
> -# Give the file a new name so we don't clobber the real one if
> -# objfile == srcdir.
>  # We also need to do this before compiling the program because the name
>  # of the script file is encoded in the binary.
>  # FIXME: Can we get gdb_remote_download to call standard_output_file for us?

Please remove this FIXME while you're at it.

>  set remote_guile_file [gdb_remote_download host \
> -			   ${srcdir}/${subdir}/${testfile}.scm \
> -			   ${subdir}/t-${testfile}.scm]
> +			   ${srcdir}/${subdir}/${testfile}.scm]
>  
>  if {[build_executable $testfile.exp $testfile $srcfile \
>  	[list debug "additional_flags=-I${srcdir}/../../include -DSCRIPT_FILE=\"$remote_guile_file\""]] == -1} {