From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/4] remove some sym_probe_fns methods
Date: Thu, 05 Dec 2013 23:06:00 -0000 [thread overview]
Message-ID: <m3txemhp8b.fsf@redhat.com> (raw)
In-Reply-To: <1386100019-27379-3-git-send-email-tromey@redhat.com> (Tom Tromey's message of "Tue, 3 Dec 2013 12:46:57 -0700")
On Tuesday, December 03 2013, Tom Tromey wrote:
> While looking into the probe API, it seemed to me that there were a
> number of methods in sym_probe_fns that were not needed. This patch
> removes them.
>
> Specifically, it seems to me that sym_probe_fns ought to be concerned
> with the API for constructing the probes. Any method relating to some
> aspect of an individual probe can be handled via the probe's own
> vtable. That is, the double indirection here doesn't seem useful --
> it certainly isn't in fact used, but also I couldn't think of a
> potential use.
This patch is great and needed, thanks a lot. The cleanup is more than
welcome.
I'll wait until you commit your patches so that I can rebase mine on top
of them.
Thanks,
--
Sergio
next prev parent reply other threads:[~2013-12-05 23:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 19:47 [PATCH 0/4] make probes independent of the program space Tom Tromey
2013-12-03 19:47 ` [PATCH 3/4] change probes to be program-space-independent Tom Tromey
2013-12-17 11:08 ` Gary Benson
2013-12-03 19:47 ` [PATCH 1/4] comment fixes Tom Tromey
2013-12-03 19:47 ` [PATCH 2/4] remove some sym_probe_fns methods Tom Tromey
2013-12-05 23:06 ` Sergio Durigan Junior [this message]
2013-12-06 2:25 ` Sergio Durigan Junior
2013-12-06 15:54 ` Tom Tromey
2013-12-06 17:26 ` Tom Tromey
2013-12-06 18:23 ` Sergio Durigan Junior
2013-12-03 20:37 ` [PATCH 4/4] move probes to be per-bfd Tom Tromey
2013-12-05 17:10 ` [PATCH 0/4] make probes independent of the program space Pedro Alves
2013-12-05 19:10 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3txemhp8b.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).