From: Tom Tromey <tromey@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Make static tracepoint with markers more OO
Date: Mon, 16 Jan 2012 17:03:00 -0000 [thread overview]
Message-ID: <m3ty3vr491.fsf@fleche.redhat.com> (raw)
In-Reply-To: <m3ty3z8cwb.fsf@gmail.com> (Sergio Durigan Junior's message of "Fri, 13 Jan 2012 20:18:28 -0200")
>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
Sergio> + if (arg && strncmp (arg, "-m", 2) == 0 && isblank (arg[2]))
Tom> I am not sure that isblank is ok to use. gdb doesn't use it anywhere
Tom> else. I suggest just using the original check.
Sergio> Yeah, well, the original check is for space and tab, and isblank does
Sergio> exactly that. I am not sure what is the deal about using it, but I
Sergio> removed as suggested.
I believe isblank was added in C99, but gdb generally uses C90.
These days, you can pretty much search for "gnulib $FUNCTION" and find
all the information you need:
http://www.gnu.org/software/gnulib/manual/html_node/isblank.html
I wouldn't mind us upgrading, or using more of gnulib, or both.
Sergio> The attached patch fixes all the issues pointed out by you and Pedro. I
Sergio> have also tested this on my machine using UST probes, and on testfarm.
Sergio> No regressions were found. Is it OK to apply?
Sergio> + if (arg && strncmp (arg, "-m", 2) == 0 && (isspace (arg[2])
Sergio> + || arg[2] == '\t'))
isspace also looks for \t, so please remove the || clause.
I have no further comments, but I would rather Pedro give the final OK
on this.
Tom
next prev parent reply other threads:[~2012-01-16 16:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 7:24 Sergio Durigan Junior
2012-01-13 11:14 ` Pedro Alves
2012-01-13 17:24 ` Sergio Durigan Junior
2012-01-16 12:32 ` Pedro Alves
2012-01-13 15:46 ` Tom Tromey
2012-01-13 23:49 ` Sergio Durigan Junior
2012-01-16 17:03 ` Tom Tromey [this message]
2012-01-16 17:10 ` Sergio Durigan Junior
2012-01-16 17:19 ` Pedro Alves
2012-01-16 19:29 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ty3vr491.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).