From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28414 invoked by alias); 20 Dec 2011 15:24:03 -0000 Received: (qmail 28406 invoked by uid 22791); 20 Dec 2011 15:24:02 -0000 X-SWARE-Spam-Status: No, hits=-5.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Dec 2011 15:23:48 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pBKFNjU8022058 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 20 Dec 2011 10:23:48 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pBKFNjBM018785; Tue, 20 Dec 2011 10:23:45 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pBKFNis4004315; Tue, 20 Dec 2011 10:23:44 -0500 From: Tom Tromey To: Keith Seitz Cc: "gp \>\> \"gdb-patches\@sourceware.org ml\"" Subject: Re: [RFA] Updated path expression computations for varobj trees References: <4EEBCC7D.4020103@redhat.com> Date: Tue, 20 Dec 2011 15:25:00 -0000 In-Reply-To: <4EEBCC7D.4020103@redhat.com> (Keith Seitz's message of "Fri, 16 Dec 2011 14:55:57 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00669.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> * lib/mi-support.exp: Expand comments about PATH_EXPR. Keith> (varobj_tree::get_path_expr): Assume that all varobjs are Keith> compound unless they are known simple types. Keith> Adjust path expressions based on parent type, path parent type, Keith> and tree language. Keith> (varobj_tree::walk_tree): Add LANGUAGE parameter and save it into Keith> the root varobj. Keith> (mi_walk_varobj_tree): Add LANGUAGE parameter. This is ok. I'm not super fond of the type regexp thing, but I suppose we can always enhance it more later if need be. Tom