From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: <gdb-patches@sourceware.org>
Subject: Re: Your INTERMEDIATE_ENCODING patch for Solaris
Date: Mon, 27 Sep 2010 18:42:00 -0000 [thread overview]
Message-ID: <m3tylbnljm.fsf@fleche.redhat.com> (raw)
In-Reply-To: <000901cb5aef$afb465b0$0f1d3110$@muller@ics-cnrs.unistra.fr> (Pierre Muller's message of "Thu, 23 Sep 2010 09:19:39 +0200")
Tom> Yeah, how about we make x0108 the minimal acceptable version?
Tom> It was released in 2002, that seems plenty old to me.
Tom> If you agree, I will make the change.
Pierre> I agree, furthermore HAVE_LIBICONVLIST
Pierre> should always be set in config.h in that case,
Pierre> which avoids the direct call to 'iconv -l'.
Here is the patch I am checking in.
Thank you for all the testing you did for this.
Tom
2010-09-27 Tom Tromey <tromey@redhat.com>
* gdb_wchar.h: Change minimum libiconv to 0x108.
Index: gdb_wchar.h
===================================================================
RCS file: /cvs/src/src/gdb/gdb_wchar.h,v
retrieving revision 1.4
diff -u -r1.4 gdb_wchar.h
--- gdb_wchar.h 15 Sep 2010 20:18:47 -0000 1.4
+++ gdb_wchar.h 27 Sep 2010 17:21:10 -0000
@@ -52,12 +52,11 @@
/* We use "btowc" as a sentinel to detect functioning wchar_t support.
We check for either __STDC_ISO_10646__ or a new-enough libiconv in
order to ensure we can convert to and from wchar_t. We choose
- libiconv version 0x10D because it was reported that earlier
- versions do not always accept "wchar_t" as an encoding
- argument. */
+ libiconv version 0x108 because it is the first version with
+ iconvlist. */
#if defined (HAVE_ICONV) && defined (HAVE_WCHAR_H) && defined (HAVE_BTOWC) \
&& (defined (__STDC_ISO_10646__) \
- || (defined (_LIBICONV_VERSION) && _LIBICONV_VERSION >= 0x10D))
+ || (defined (_LIBICONV_VERSION) && _LIBICONV_VERSION >= 0x108))
#include <wchar.h>
#include <wctype.h>
@@ -84,7 +83,7 @@
#else
#define INTERMEDIATE_ENCODING "UCS-4LE"
#endif
-#elif defined (_LIBICONV_VERSION) && _LIBICONV_VERSION >= 0x10D
+#elif defined (_LIBICONV_VERSION) && _LIBICONV_VERSION >= 0x108
#define INTERMEDIATE_ENCODING "wchar_t"
#else
/* This shouldn't happen, because the earlier #if should have filtered
next prev parent reply other threads:[~2010-09-27 17:28 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-31 16:25 Kazu Hirata
2010-08-05 18:40 ` Tom Tromey
2010-08-10 20:28 ` Daniel Jacobowitz
2010-08-17 18:06 ` Tom Tromey
2010-08-17 18:44 ` Joel Brobecker
2010-08-17 19:03 ` Tom Tromey
2010-08-18 10:14 ` Joel Brobecker
2010-08-18 14:43 ` Pierre Muller
2010-08-18 14:52 ` Joel Brobecker
2010-08-18 15:10 ` Pierre Muller
2010-08-18 15:35 ` Tom Tromey
2010-08-18 15:44 ` Tom Tromey
2010-08-18 16:36 ` Joel Brobecker
2010-08-18 17:35 ` Tom Tromey
2010-08-18 17:41 ` Joel Brobecker
[not found] ` <15264.6257346079$1282142643@news.gmane.org>
2010-08-18 16:12 ` Tom Tromey
2010-08-19 15:03 ` Pierre Muller
2010-08-19 16:09 ` Tom Tromey
2010-08-30 18:01 ` Tom Tromey
2010-08-31 9:25 ` Pierre Muller
2010-08-31 16:47 ` Tom Tromey
2010-09-01 7:30 ` Pierre Muller
[not found] ` <44796.6229789474$1283326243@news.gmane.org>
2010-09-01 22:35 ` Tom Tromey
2010-09-02 14:21 ` Pierre Muller
2010-09-02 15:39 ` Tom Tromey
2010-09-14 21:29 ` Tom Tromey
2010-09-15 17:20 ` Pierre Muller
2010-09-16 7:55 ` Tom Tromey
2010-09-16 9:49 ` Pierre Muller
2010-09-16 20:22 ` Tom Tromey
2010-09-16 22:31 ` Pierre Muller
[not found] ` <20078.2261243605$1284672670@news.gmane.org>
2010-09-17 9:21 ` Tom Tromey
2010-09-17 13:48 ` Pierre Muller
2010-09-23 13:00 ` Tom Tromey
2010-09-23 14:48 ` Pierre Muller
2010-09-27 18:42 ` Tom Tromey [this message]
2010-09-16 17:51 ` [patch] Regression on py-prettyprint.exp: print estring [Re: Your INTERMEDIATE_ENCODING patch for Solaris] Jan Kratochvil
2010-09-16 20:33 ` Tom Tromey
2010-09-16 20:44 ` Jan Kratochvil
2010-08-18 11:52 ` Your INTERMEDIATE_ENCODING patch for Solaris Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3tylbnljm.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).