[patch] ser-pipe.c (pipe_open): Ignore SIGINTs in child.

[patch] ser-pipe.c (pipe_open): Ignore SIGINTs in child.

[Doug Evans]

I was debugging "tar rem | ..." today and found that typing ^c
killed the child of the pipe.

I will check this in in a few days if there are no objections.

2010-04-26  Doug Evans  <dje@google.com>

	* ser-pipe.c (pipe_open): Ignore SIGINTs in child.

Index: ser-pipe.c
===================================================================
RCS file: /cvs/src/src/gdb/ser-pipe.c,v
retrieving revision 1.24
diff -u -p -r1.24 ser-pipe.c
--- ser-pipe.c	20 Apr 2010 05:52:07 -0000	1.24
+++ ser-pipe.c	27 Apr 2010 03:49:05 -0000
@@ -98,6 +98,8 @@ pipe_open (struct serial *scb, const cha
   /* Child. */
   if (pid == 0)
     {
+      signal (SIGINT, SIG_IGN);
+
       /* re-wire pdes[1] to stdin/stdout */
       close (pdes[0]);
       if (pdes[1] != STDOUT_FILENO)

Re: [patch] ser-pipe.c (pipe_open): Ignore SIGINTs in child.

[Tom Tromey]

>>>>> "Doug" == Doug Evans <dje@google.com> writes:

Doug> I was debugging "tar rem | ..." today and found that typing ^c
Doug> killed the child of the pipe.

I think it is preferable to call setsid, so that the child is dissociated
from the controlling terminal.  That way C-c won't send it a SIGINT.

Tom

Re: [patch] ser-pipe.c (pipe_open): Ignore SIGINTs in child.

[Doug Evans]

On Tue, Apr 27, 2010 at 10:43 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>
> Doug> I was debugging "tar rem | ..." today and found that typing ^c
> Doug> killed the child of the pipe.
>
> I think it is preferable to call setsid, so that the child is dissociated
> from the controlling terminal.  That way C-c won't send it a SIGINT.

#ifdef HAVE_SETSID

sounds good.

[create_tty_session doesn't have any code to handle, e.g., win32, so
punt to SIG_IGN #ifndef HAVE_SETSID?]

Re: [patch] ser-pipe.c (pipe_open): Ignore SIGINTs in child.

[Tom Tromey]

>>>>> "Doug" == Doug Evans <dje@google.com> writes:

Doug> [create_tty_session doesn't have any code to handle, e.g., win32, so
Doug> punt to SIG_IGN #ifndef HAVE_SETSID?]

I don't know what to do in that case.

Tom