From: Doug Evans <xdje42@gmail.com>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v6 6/9] Explicit locations: introduce explicit locations
Date: Mon, 10 Aug 2015 18:09:00 -0000 [thread overview]
Message-ID: <m3vbcnc8yq.fsf@sspiff.org> (raw)
In-Reply-To: <20150805233023.21646.98811.stgit@valrhona.uglyboxes.com> (Keith Seitz's message of "Wed, 05 Aug 2015 16:32:42 -0700")
Keith Seitz <keiths@redhat.com> writes:
> * This patch was previously approved but has been modified. *
>
> Differences in this revision:
>
> 1. Fix memory leak in canonicalize_linespec.
>
> --
>
> This patch add support for explicit locations and switches many linespec
> locations to this new location type. This patch also converts all
> linespec locations entered by the user to an explicit representation
> internally (thus bypassing the linespec parser when resetting the
> breakpoint).
>
> This patch does not introduce any user-visible changes.
>
>
> gdb/ChangeLog:
>
> * break-catch-throw.c (re_set_exception_catchpoint): Convert
> linespec into explicit location.
> * breakpoint.c (create_overlay_breakpoint)
> (create_longjmp_master_breakpoint)
> (create_std_terminate_master_breakpoint)
> (create_exception_master_breakpoint): Convert linespec into explicit
> location.
> (update_static_tracepoint): Convert linespec into explicit location.
> * linespec.c (enum offset_relative_sign, struct line_offset): Move
> location.h.
> (struct linespec) <expression, expr_pc, source_filename>
> <function_name, label_name, line_offset>: Replace with ...
> <explicit>: ... this.
> <is_linespec>: New member.
> (PARSER_EXPLICIT): New accessor macro.
> (undefined_label_error): New function.
> (source_file_not_found_error): New function.
> (linespec_parse_basic): The parser result is now an explicit location.
> Use PARSER_EXPLICIT to access it.
> Use undefined_label_error.
> (canonicalize_linespec): Convert canonical linespec into explicit
> location.
> Move string representation of location to explicit_location_to_linespec
> and use it and explicit_location_to_string to save string
> representations of the canonical location.
> (create_sals_line_offset, convert_linespec_to_sals): `ls' contains an
> explicit location. Update all references.
> (convert_explicit_location_to_sals): New function.
> (parse_linespec): Use PARSER_EXPLICIT to access the parser
> result's explicit location.
> (linespec_state_constructor): Initialize is_linespec.
> Use PARSER_EXPLICIT.
> (linespec_parser_delete): Use PARSER_EXPLICIT to access the parser's
> result.
> (event_location_to_sals): For linespec locations, set is_linespec.
> Handle explicit locations.
> (decode_objc): 'ls' contains an explicit location now. Update all
> references.
> (symtabs_from_filename): Use source_file_not_found_error.
> * location.c (struct event_location.u) <explicit>: New member.
> (initialize_explicit_location): New function.
> (initialize_event_location): Initialize explicit locations.
> (new_explicit_location, get_explicit_location)
> (get_explicit_location_const): New functions.
> (explicit_to_string_internal): New function; most of contents moved
> from canonicalize_linespec.
> (explicit_location_to_string): New function.
> (explicit_location_to_linespec): New function.
> (copy_event_location, delete_event_location)
> (event_location_to_string_const, event_location_empty_p): Handle
> explicit locations.
> * location.h (enum offset_relative_sign, struct line_offset): Move
> here from linespec.h.
> (enum event_location_type): Add EXPLICIT_LOCATION.
> (struct explicit_location): New structure.
> (explicit_location_to_string): Declare.
> (explicit_location_to_linespec): Declare.
> (new_explicit_location, get_explicit_locationp
> (get_explicit_location_const, initialize_explicit_location): Declare.
LGTM
next prev parent reply other threads:[~2015-08-10 18:09 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 23:28 [PATCH v6 0/9] Series short description Keith Seitz
2015-08-05 23:29 ` [PATCH v6 1/9] Explicit locations: rename "address string"/"addr_string" to "location" Keith Seitz
2015-08-10 16:43 ` Doug Evans
2015-08-05 23:29 ` [PATCH v6 2/9] Explicit locations: introduce new struct event_location-based API Keith Seitz
2015-08-10 17:34 ` Doug Evans
2015-08-10 18:05 ` Keith Seitz
2015-08-10 19:59 ` Doug Evans
2015-08-11 20:45 ` [PATCH v6 2/9] Explicit locations: introduce new struct event_locations-based API Keith Seitz
2015-08-11 21:49 ` Doug Evans
2015-08-05 23:29 ` [PATCH v6 3/9] Explicit locations: use new location API Keith Seitz
2015-08-10 18:02 ` Doug Evans
2015-08-05 23:30 ` [PATCH v6 5/9] Explicit locations: introduce probe locations Keith Seitz
2015-08-10 18:06 ` Doug Evans
2015-08-05 23:30 ` [PATCH v6 4/9] Explicit locations: introduce address locations Keith Seitz
2015-08-10 18:04 ` Doug Evans
2015-12-14 7:11 ` Joel Brobecker
2015-12-14 20:56 ` Keith Seitz
2015-12-15 13:40 ` Joel Brobecker
2016-01-17 15:32 ` [RFA] Fix regression introduced in "break *<EXPR>" by explicit location patches (was: "Re: [PATCH v6 4/9] Explicit locations: introduce address locations") Joel Brobecker
2016-01-18 21:29 ` [RFA] Fix regression introduced in "break *<EXPR>" by explicit location patches Keith Seitz
2016-01-21 10:33 ` Joel Brobecker
2015-08-05 23:32 ` [PATCH v6 6/9] Explicit locations: introduce explicit locations Keith Seitz
2015-08-10 18:09 ` Doug Evans [this message]
2015-08-05 23:33 ` [PATCH v6 8/9] Explicit locations: MI support for " Keith Seitz
2015-08-10 19:43 ` Doug Evans
2015-08-05 23:33 ` [PATCH v6 7/9] Explicit locations: add UI features for CLI Keith Seitz
2015-08-10 19:42 ` Doug Evans
2015-08-11 20:45 ` Keith Seitz
2015-08-11 21:50 ` Doug Evans
2015-08-17 16:41 ` Yao Qi
2015-08-17 17:19 ` Keith Seitz
2015-08-05 23:34 ` [PATCH v6 9/9] Explicit locations: documentation updates Keith Seitz
2015-08-10 19:45 ` Doug Evans
2015-08-10 19:54 ` [PATCH v6 0/9] Series short description Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vbcnc8yq.fsf@sspiff.org \
--to=xdje42@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).