From: Doug Evans <xdje42@gmail.com>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3 5/9] Explicit locations: introduce probe locations
Date: Sun, 01 Mar 2015 21:03:00 -0000 [thread overview]
Message-ID: <m3vbikjurb.fsf@sspiff.org> (raw)
In-Reply-To: <20150217220648.1312.61126.stgit@valrhona.uglyboxes.com> (Keith Seitz's message of "Tue, 17 Feb 2015 14:06:48 -0800")
Keith Seitz <keiths@redhat.com> writes:
> This patch adds support for probe locations and converts existing
> probe linespec locations to the new location type.
>
> gdb/ChangeLog:
>
> * break-catch-throw.c (re_set_exception_catchpoint): Convert
> linespec for stap probe to probe location.
> * breakpoint.c (create_longjmp_master_breakpoint): Likewise.
> (create_exception_master_breakpoint): Likewise.
> (break_command_1): Remove local variable `arg_cp'.
> Check location type to set appropriate breakpoint ops methods.
> (trace_command): Likewise.
> * linespec.c (event_location_to_sals): Assert on probe locations.
> * location.c (EL_PROBE): Add macro definition.
> (new_probe_location, get_probe_location): New functions.
> (copy_event_location): Handle probe locations.
> (delete_event_location): Likewise.
> (event_location_to_string): Likewise.
> (string_to_event_location): Likewise.
> (event_location_empty_p): Likewise.
> * location.h (enum event_location_type): Add PROBE_LOCATION.
> (new_probe_location, get_probe_location): Declare.
> * probe.c (parse_probes): Assert that LOCATION is a probe location.
> Convert linespec into probe location.
LGTM
next prev parent reply other threads:[~2015-03-01 21:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 22:06 [PATCH v3 0/9] Locations API Keith Seitz
2015-02-17 22:06 ` [PATCH v3 4/9] Explicit locations: introduce address locations Keith Seitz
2015-03-01 21:03 ` Doug Evans
2015-05-07 17:05 ` Keith Seitz
2015-02-17 22:06 ` [PATCH v3 1/9] Explicit locations: rename "address string"/"addr_string" to "location" Keith Seitz
2015-03-01 20:08 ` Doug Evans
2015-02-17 22:06 ` [PATCH v3 2/9] Explicit locations: introduce new struct event_location-based API Keith Seitz
2015-03-01 20:14 ` Doug Evans
2015-05-07 16:59 ` Keith Seitz
2015-02-17 22:07 ` [PATCH v3 5/9] Explicit locations: introduce probe locations Keith Seitz
2015-03-01 21:03 ` Doug Evans [this message]
2015-02-17 22:07 ` [PATCH v3 8/9] Explicit locations: MI support for explicit locations Keith Seitz
2015-03-01 21:15 ` Doug Evans
2015-02-17 22:07 ` [PATCH v3 6/9] Explicit locations: introduce " Keith Seitz
2015-03-01 21:04 ` Doug Evans
2015-02-17 22:07 ` [PATCH v3 7/9] Explicit locations: add UI features for CLI Keith Seitz
2015-03-01 21:14 ` Doug Evans
2015-05-07 17:07 ` Keith Seitz
2015-02-17 22:07 ` [PATCH v3 3/9] Explicit locations: use new location API Keith Seitz
2015-03-01 20:54 ` Doug Evans
2015-05-07 17:03 ` Keith Seitz
2015-02-17 22:50 ` [PATCH v3 9/9] Explicit locations: documentation updates Keith Seitz
2015-03-01 21:25 ` Doug Evans
2015-05-07 17:07 ` Keith Seitz
2015-02-23 4:17 ` [PATCH v3 0/9] Locations API Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vbikjurb.fsf@sspiff.org \
--to=xdje42@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).