From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4260 invoked by alias); 28 Dec 2013 21:25:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4251 invoked by uid 89); 28 Dec 2013 21:25:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 28 Dec 2013 21:25:35 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBSLPR3w026362 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 28 Dec 2013 16:25:28 -0500 Received: from psique ([10.3.113.9]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBSLPNOD029553 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sat, 28 Dec 2013 16:25:26 -0500 From: Sergio Durigan Junior To: Joel Brobecker Cc: GDB Patches , Marcus Shawcroft , Yufeng Zhang Subject: Re: [PATCH] Extend handling of immediates on ARM's SystemTap SDT probe support References: <20131228034121.GF4532@adacore.com> X-URL: http://www.redhat.com Date: Sat, 28 Dec 2013 21:25:00 -0000 In-Reply-To: <20131228034121.GF4532@adacore.com> (Joel Brobecker's message of "Sat, 28 Dec 2013 07:41:21 +0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00981.txt.bz2 On Saturday, December 28 2013, Joel Brobecker wrote: >> diff --git a/gdb/arm-linux-tdep.c b/gdb/arm-linux-tdep.c >> index 0284f69..df2b8c4 100644 >> --- a/gdb/arm-linux-tdep.c >> +++ b/gdb/arm-linux-tdep.c >> @@ -1116,7 +1116,7 @@ arm_linux_displaced_step_copy_insn (struct gdbarch *gdbarch, >> static int >> arm_stap_is_single_operand (struct gdbarch *gdbarch, const char *s) >> { >> - return (*s == '#' /* Literal number. */ >> + return (*s == '#' || *s == '$' || isdigit (*s) /* Literal number. */ >> || *s == '[' /* Register indirection or >> displacement. */ >> || isalpha (*s)); /* Register value. */ >> @@ -1183,14 +1183,19 @@ arm_stap_parse_special_token (struct gdbarch *gdbarch, >> >> ++tmp; >> tmp = skip_spaces_const (tmp); >> - if (*tmp++ != '#') >> - return 0; >> + if (*tmp == '#' || *tmp == '$') >> + ++tmp; >> >> if (*tmp == '-') >> { >> ++tmp; >> got_minus = 1; >> } >> + else if (*tmp == '+') >> + ++tmp; >> + >> + if (!isdigit (*tmp)) >> + return 0; >> > > I think you mixed in one change which is unrelated to this patch > (the handling of the '+' sign). Perhaps you had meant to have it > as part of the first patch? > > [PATCH v2] Fix for PR tdep/15653: Implement SystemTap SDT probe > support for AArch64 > http://www.sourceware.org/ml/gdb-patches/2013-12/msg00887.html > > IIRC, this patch was born by extraction out of v1 of the patch above. > > If I am correct, this patch is pre-approved with the '+' bit moved to > the correct patch. You are indeed correct that this change doesn't belong to this patch, but it also doesn't belong to the AArch64 patch (that's why I didn't include it there). I will actually post a separate patch for this change. In fact, there are some other places that could use this improvement too, so this new patch will include those as well. Having said that, I removed this piece from the patch and committed the rest. Thank you a lot for the review! -- Sergio