From: Tom Tromey <tromey@redhat.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [Oleg Nesterov] PATCH? gdb remote.c: readchar() should pop_target() if SERIAL_ERROR?
Date: Wed, 28 Jul 2010 17:28:00 -0000 [thread overview]
Message-ID: <m3vd7zms77.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4C4F55AE.4010507@vmware.com> (Michael Snyder's message of "Tue, 27 Jul 2010 14:54:54 -0700")
>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
Michael> Tom Tromey wrote:
>> I am forwarding this from the archer list because I think this report is
>> reasonably complete -- I couldn't really improve on it.
>>
>> Please comment on this patch. I don't know this area of gdb well.
>>
>> If the enclosed has insufficient information, please contact me and I
>> will get whatever is needed. Thanks.
Michael> I'm sorry I haven't been able to recall how I've encountered this
Michael> symptom, so I can't provide a meaningful review.
Michael> Is there a chance of getting this into the 7.2 release?
The change seems correct to me, and I'm interested in getting it in.
But since I don't know this code well I am reluctant to commit it
without someone else's ok. If that isn't forthcoming I will try to look
into the code more deeply and see if I can figure it out. Maybe I can
do some kind of failure injection to see the bug live.
Tom
next prev parent reply other threads:[~2010-07-28 17:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-09 19:57 Tom Tromey
2010-07-12 18:11 ` Michael Snyder
2010-07-27 21:55 ` Michael Snyder
2010-07-28 17:28 ` Tom Tromey [this message]
2010-07-28 19:49 ` Pedro Alves
2010-07-28 20:20 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vd7zms77.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).