From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83986 invoked by alias); 22 Feb 2017 17:38:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 83976 invoked by uid 89); 22 Feb 2017 17:38:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=retried X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Feb 2017 17:38:19 +0000 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v1MHXmV0063072 for ; Wed, 22 Feb 2017 12:38:18 -0500 Received: from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110]) by mx0b-001b2d01.pphosted.com with ESMTP id 28sf3hra94-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 22 Feb 2017 12:38:18 -0500 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 22 Feb 2017 17:38:16 -0000 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp14.uk.ibm.com (192.168.101.144) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 22 Feb 2017 17:38:14 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id F41272190019; Wed, 22 Feb 2017 17:37:15 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v1MHcEbx8061264; Wed, 22 Feb 2017 17:38:14 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C9756AE045; Wed, 22 Feb 2017 16:36:04 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A80AEAE063; Wed, 22 Feb 2017 16:36:04 +0000 (GMT) Received: from oc1027705133.ibm.com (unknown [9.152.212.222]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Wed, 22 Feb 2017 16:36:04 +0000 (GMT) From: Andreas Arnez To: Jan Kratochvil Cc: gdb-patches@sourceware.org, Victor Leschuk Subject: Re: [PATCH v2 4/8] DWARF-5 basic functionality References: <148753968011.4016.6818202131640662529.stgit@host1.jankratochvil.net> <148753970532.4016.14210350935498491454.stgit@host1.jankratochvil.net> <20170222142857.GA25383@host1.jankratochvil.net> Date: Wed, 22 Feb 2017 17:38:00 -0000 In-Reply-To: <20170222142857.GA25383@host1.jankratochvil.net> (Jan Kratochvil's message of "Wed, 22 Feb 2017 15:28:57 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17022217-0016-0000-0000-000004442DE7 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17022217-0017-0000-0000-0000268B26D5 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-22_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1702220161 X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00596.txt.bz2 On Wed, Feb 22 2017, Jan Kratochvil wrote: > What compiler/version/options do you use? I have tried now > gcc-4.8.5-11.el7.x86_64 > CFLAGS=-O3 CXXFLAGS=-O3 ./configure;make I saw the warning with an upstream GCC I recently built myself for s390x. Today I retried with a fresh version from GCC git, with the same result: gcc (GCC) 7.0.1 20170222 (experimental) > While I get some warnings/errors none of them is in dwarf2read.c. > > I do not want to patch it without reproducibility of the warnings. Sure. Unfortunately the maybe-uninitialized warnings highly depend on compiler version, platform, optimization level, etc. Since this is a false positive, I don't necessarily propose a change in this case. [...] >> But then I wonder >> about the effect of the call to create_debug_type_hash_table in >> create_all_type_units: >> >> create_debug_type_hash_table (NULL, &dwarf2_per_objfile->info, types_htab, >> rcuh_kind::COMPILE); >> >> Is that needed? > > Yes. Otherwise GDB would not read definitions of classes during > -gdwarf-5 -fdebug-types-section > as then DW_UT_type are located inside .debug_info. Ah, I see; thanks for explanation. Seems I was misled by the function description that mentions "all entries in the .debug_types section", but fails to mention the .debug_info section. I also stumbled upon the fact that read_comp_unit_head performs the conditional initialization under "if (section_kind == rcuh_kind::TYPE)" instead of checking for the appropriate unit type. This works because section_kind is adjusted accordingly above, but it might be clearer otherwise. -- Andreas