From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7764 invoked by alias); 16 Dec 2013 17:16:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7755 invoked by uid 89); 16 Dec 2013 17:16:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Dec 2013 17:16:14 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBGHGCcR030820 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 16 Dec 2013 12:16:13 -0500 Received: from psique (ovpn-113-60.phx2.redhat.com [10.3.113.60]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rBGHGAsw025764 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 16 Dec 2013 12:16:12 -0500 From: Sergio Durigan Junior To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Extend SystemTap SDT probe argument parser References: <1386734160-29837-1-git-send-email-sergiodj@redhat.com> <201312161708.rBGH8m8L017003@glazunov.sibelius.xs4all.nl> X-URL: http://www.redhat.com Date: Mon, 16 Dec 2013 17:16:00 -0000 In-Reply-To: <201312161708.rBGH8m8L017003@glazunov.sibelius.xs4all.nl> (Mark Kettenis's message of "Mon, 16 Dec 2013 18:08:48 +0100 (CET)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00586.txt.bz2 On Monday, December 16 2013, Mark Kettenis wrote: >> From: Sergio Durigan Junior >> Date: Mon, 16 Dec 2013 15:01:38 -0200 >> >> On Wednesday, December 11 2013, I wrote: >> >> > This patch extends the current generic parser for SystemTap SDT probe >> > arguments. It can be almost considered a cleanup, but the main point of >> > it is actually to allow the generic parser to accept multiple prefixes >> > and suffixes for the its operands (i.e., integers, register names, and >> > register indirection). >> >> Ping. > > Can't say I like the added complexity, but the i386/amd64 are ok. Thanks for the approval. I wonder what exactly you didn't like, and if you have some opinion on how to improve it. Thanks, -- Sergio