public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Subject: FYI: make python install directory
Date: Wed, 18 Aug 2010 22:55:00 -0000	[thread overview]
Message-ID: <m3wrrn8rah.fsf@fleche.redhat.com> (raw)

I'm checking this in on the trunk and the 7.2 branch.

PR 11900 says that gdb's breaks help with Python 2.4.
This happens because the gdb module's __path__ points to a directory
which does not exist.

This patch fixes the problem by arranging to make the appropriate
directory at install time.

Joel, I'm afraid your patches in this area will need a small update.
Or you can just back this out when those go in -- it doesn't matter at
all to me.  I went with this very minimal patch just because it seems
important to fix for 7.2.

Tom

2010-08-18  Tom Tromey  <tromey@redhat.com>

	PR python/11900:
	* configure: Rebuild.
	* configure.ac: Add install-python to CONFIG_INSTALL.
	* Makefile.in (install-python): New.

Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.1127.2.1
diff -u -r1.1127.2.1 Makefile.in
--- Makefile.in	28 Jul 2010 18:32:47 -0000	1.1127.2.1
+++ Makefile.in	18 Aug 2010 22:52:22 -0000
@@ -1037,6 +1037,8 @@
 		$(INSTALL_DATA) $(srcdir)/gdb.1 \
 			$(DESTDIR)$(man1dir)/$$transformed_name.1
 
+install-python:
+	$(SHELL) $(srcdir)/../mkinstalldirs $(GDB_DATADIR)/python/gdb
 
 uninstall: force $(CONFIG_UNINSTALL)
 	transformed_name=`t='$(program_transform_name)'; \
Index: configure.ac
===================================================================
RCS file: /cvs/src/src/gdb/configure.ac,v
retrieving revision 1.125.2.2
diff -u -r1.125.2.2 configure.ac
--- configure.ac	30 Jul 2010 16:02:16 -0000	1.125.2.2
+++ configure.ac	18 Aug 2010 22:52:23 -0000
@@ -832,6 +832,7 @@
   CONFIG_OBS="$CONFIG_OBS \$(SUBDIR_PYTHON_OBS)"
   CONFIG_DEPS="$CONFIG_DEPS \$(SUBDIR_PYTHON_DEPS)"
   CONFIG_SRCS="$CONFIG_SRCS \$(SUBDIR_PYTHON_SRCS)"
+  CONFIG_INSTALL="$CONFIG_INSTALL install-python"
   ENABLE_CFLAGS="$ENABLE_CFLAGS \$(SUBDIR_PYTHON_CFLAGS)"
 
   # Flags needed to compile Python code (taken from python-config --cflags).

             reply	other threads:[~2010-08-18 22:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-18 22:55 Tom Tromey [this message]
2010-08-19 18:03 ` Michael Snyder
2010-08-19 18:11   ` Michael Snyder
2010-08-19 18:26     ` Joel Brobecker
2010-08-19 18:39       ` Daniel Jacobowitz
2010-08-19 18:38   ` Tom Tromey
2010-08-23 18:27     ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3wrrn8rah.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).