From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26500 invoked by alias); 18 Aug 2010 22:55:26 -0000 Received: (qmail 26492 invoked by uid 22791); 18 Aug 2010 22:55:26 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Aug 2010 22:55:21 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7IMtKOR023614 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 18 Aug 2010 18:55:20 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7IMtJtf010540; Wed, 18 Aug 2010 18:55:19 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o7IMtJn7003011; Wed, 18 Aug 2010 18:55:19 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id D44BB378196; Wed, 18 Aug 2010 16:55:18 -0600 (MDT) From: Tom Tromey To: gdb-patches@sourceware.org Subject: FYI: make python install directory Date: Wed, 18 Aug 2010 22:55:00 -0000 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00323.txt.bz2 I'm checking this in on the trunk and the 7.2 branch. PR 11900 says that gdb's breaks help with Python 2.4. This happens because the gdb module's __path__ points to a directory which does not exist. This patch fixes the problem by arranging to make the appropriate directory at install time. Joel, I'm afraid your patches in this area will need a small update. Or you can just back this out when those go in -- it doesn't matter at all to me. I went with this very minimal patch just because it seems important to fix for 7.2. Tom 2010-08-18 Tom Tromey PR python/11900: * configure: Rebuild. * configure.ac: Add install-python to CONFIG_INSTALL. * Makefile.in (install-python): New. Index: Makefile.in =================================================================== RCS file: /cvs/src/src/gdb/Makefile.in,v retrieving revision 1.1127.2.1 diff -u -r1.1127.2.1 Makefile.in --- Makefile.in 28 Jul 2010 18:32:47 -0000 1.1127.2.1 +++ Makefile.in 18 Aug 2010 22:52:22 -0000 @@ -1037,6 +1037,8 @@ $(INSTALL_DATA) $(srcdir)/gdb.1 \ $(DESTDIR)$(man1dir)/$$transformed_name.1 +install-python: + $(SHELL) $(srcdir)/../mkinstalldirs $(GDB_DATADIR)/python/gdb uninstall: force $(CONFIG_UNINSTALL) transformed_name=`t='$(program_transform_name)'; \ Index: configure.ac =================================================================== RCS file: /cvs/src/src/gdb/configure.ac,v retrieving revision 1.125.2.2 diff -u -r1.125.2.2 configure.ac --- configure.ac 30 Jul 2010 16:02:16 -0000 1.125.2.2 +++ configure.ac 18 Aug 2010 22:52:23 -0000 @@ -832,6 +832,7 @@ CONFIG_OBS="$CONFIG_OBS \$(SUBDIR_PYTHON_OBS)" CONFIG_DEPS="$CONFIG_DEPS \$(SUBDIR_PYTHON_DEPS)" CONFIG_SRCS="$CONFIG_SRCS \$(SUBDIR_PYTHON_SRCS)" + CONFIG_INSTALL="$CONFIG_INSTALL install-python" ENABLE_CFLAGS="$ENABLE_CFLAGS \$(SUBDIR_PYTHON_CFLAGS)" # Flags needed to compile Python code (taken from python-config --cflags).