From: Tom Tromey <tromey@redhat.com>
To: sami wagiaalla <swagiaal@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] function eval cleanup
Date: Tue, 20 Jul 2010 19:57:00 -0000 [thread overview]
Message-ID: <m3wrsq9ba9.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4C45F37C.1080401@redhat.com> (sami wagiaalla's message of "Tue, 20 Jul 2010 15:05:32 -0400")
>>>>> "Sami" == sami wagiaalla <swagiaal@redhat.com> writes:
Sami> Corrected pre-overload-resolution function evaluation.
Sami> 2010-07-20 Sami Wagiaalla <swagiaal@redhat.com>
Sami> * eval.c (evaluate_subexp_standard): Disabled evaluation of C++
Sami> function symbols before overload resolution.
Looks good.
Just one detail...
Sami> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable \
Sami> + {debug c++}] != "" } {
Sami> + untested "Couldn't compile test program"
Sami> + return -1
Sami> +}
Sami> +
Sami> +# Get things started.
Sami> +
Sami> +gdb_exit
Sami> +gdb_start
Sami> +gdb_reinitialize_dir $srcdir/$subdir
Sami> +gdb_load ${binfile}
These days, prepare_for_testing is preferred instead of all the
boilerplate.
Ok with that change.
Tom
prev parent reply other threads:[~2010-07-20 19:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 18:51 sami wagiaalla
2010-07-14 23:00 ` Tom Tromey
2010-07-19 15:28 ` sami wagiaalla
2010-07-20 19:05 ` sami wagiaalla
2010-07-20 19:57 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3wrsq9ba9.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=swagiaal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).