From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-74423-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16382 invoked by alias); 20 Jul 2010 19:57:29 -0000
Received: (qmail 16364 invoked by uid 22791); 20 Jul 2010 19:57:27 -0000
X-SWARE-Spam-Status: No, hits=-6.0 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Jul 2010 19:57:21 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6KJvJaS027974	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Tue, 20 Jul 2010 15:57:19 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o6KJvJpM021186;	Tue, 20 Jul 2010 15:57:19 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o6KJvI4b002161;	Tue, 20 Jul 2010 15:57:19 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id 75F323797EE; Tue, 20 Jul 2010 13:57:18 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: sami wagiaalla <swagiaal@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] function eval cleanup
References: <4C3B6428.8090906@redhat.com> <m3630hmzye.fsf@fleche.redhat.com>	<4C446F00.5060709@redhat.com> <4C45F37C.1080401@redhat.com>
Date: Tue, 20 Jul 2010 19:57:00 -0000
In-Reply-To: <4C45F37C.1080401@redhat.com> (sami wagiaalla's message of "Tue,	20 Jul 2010 15:05:32 -0400")
Message-ID: <m3wrsq9ba9.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-07/txt/msg00314.txt.bz2

>>>>> "Sami" == sami wagiaalla <swagiaal@redhat.com> writes:

Sami> Corrected pre-overload-resolution function evaluation.
Sami> 2010-07-20  Sami Wagiaalla  <swagiaal@redhat.com>
Sami> 	* eval.c (evaluate_subexp_standard): Disabled evaluation of C++
Sami> 	function symbols before overload resolution.

Looks good.

Just one detail...

Sami> +if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable \
Sami> +      {debug c++}] != "" } {
Sami> +    untested "Couldn't compile test program"
Sami> +    return -1
Sami> +}
Sami> +
Sami> +# Get things started.
Sami> +
Sami> +gdb_exit
Sami> +gdb_start
Sami> +gdb_reinitialize_dir $srcdir/$subdir
Sami> +gdb_load ${binfile}

These days, prepare_for_testing is preferred instead of all the
boilerplate.

Ok with that change.

Tom