From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124518 invoked by alias); 30 Jan 2018 16:12:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124371 invoked by uid 89); 30 Jan 2018 16:12:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=s390 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Jan 2018 16:12:01 +0000 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w0UG8jWP137735 for ; Tue, 30 Jan 2018 11:12:00 -0500 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0b-001b2d01.pphosted.com with ESMTP id 2ftuq8946g-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 30 Jan 2018 11:11:59 -0500 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 30 Jan 2018 16:11:58 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 30 Jan 2018 16:11:56 -0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w0UGBufR46465118; Tue, 30 Jan 2018 16:11:56 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3BBF2AE051; Tue, 30 Jan 2018 16:03:22 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 16ADDAE055; Tue, 30 Jan 2018 16:03:22 +0000 (GMT) Received: from oc1027705133.ibm.com (unknown [9.152.212.130]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 30 Jan 2018 16:03:22 +0000 (GMT) From: Andreas Arnez To: Philipp Rudo Cc: GDB Patches , Ulrich Weigand Subject: Re: [PATCH] s390: Fix gdb.base/all-architectures.exp with --enable-targets=all In-Reply-To: <20180125100828.7599-2-prudo@linux.vnet.ibm.com> (Philipp Rudo's message of "Thu, 25 Jan 2018 11:08:28 +0100") References: <20180125100828.7599-1-prudo@linux.vnet.ibm.com> <20180125100828.7599-2-prudo@linux.vnet.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) Date: Tue, 30 Jan 2018 16:12:00 -0000 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 x-cbid: 18013016-0040-0000-0000-0000040A7C81 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18013016-0041-0000-0000-0000260E1521 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-30_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801300201 X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00631.txt.bz2 On Thu, Jan 25 2018, Philipp Rudo wrote: > gdb/ChangeLog: > > * s390-linux-tdep.c: Move includes for features/s390-linux32.c and > features/s390x-linux64.c to s390-tdep.c. > (_initialize_s390_linux_tdep): Move initializaion of tdesc > s390_linux32 and s390x_linux64 to s390-tdep.c. > (s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set default > tdesc. > * s390-tdep.c: Add include of features/s390-linux32.c and > features/s390x-linux64.c. > (s390_tdesc_valid): Add check for tdesc_has_registers. > (s390_gdbarch_init): Make sure there is always an valid tdesc. > (_initialize_s390_tdep): Initialize tdesc_s390_linux32 and > tdesc_s390x_linux64. > * s390-linux-tdep.h: Move export of tdesc_s390_linux32 and > tdesc_s390x_linux64 to ... > * s390-tdep.h: ... here. Looks OK. Pushed with minor spelling fixes as c81e88797907f. -- Andreas