From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10418 invoked by alias); 4 Feb 2011 20:29:47 -0000 Received: (qmail 10410 invoked by uid 22791); 4 Feb 2011 20:29:47 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Feb 2011 20:29:39 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p14KTccg030273 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 4 Feb 2011 15:29:38 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p14KTbAS026697; Fri, 4 Feb 2011 15:29:37 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p14KTb1L030510; Fri, 4 Feb 2011 15:29:37 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id B884D3784E1; Fri, 4 Feb 2011 13:29:36 -0700 (MST) From: Tom Tromey To: sami wagiaalla Cc: gdb-patches@sourceware.org Subject: Re: [patch] Support inferior events in python References: <4D2342A2.7060102@redhat.com> <4D34AF3F.4090006@redhat.com> <4D39FFFD.80304@redhat.com> <4D49C69A.20401@redhat.com> <4D4ADA8A.40507@redhat.com> <4D4C5C4D.4070708@redhat.com> Date: Fri, 04 Feb 2011 20:29:00 -0000 In-Reply-To: <4D4C5C4D.4070708@redhat.com> (sami wagiaalla's message of "Fri, 04 Feb 2011 15:06:37 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00095.txt.bz2 >>>>> "Sami" == sami wagiaalla writes: Sami> Did you mean "or, get_event_thread" here ? I assumed so because Sami> get_event_thread can indeed return NULL without setting an error. I Sami> have fixed that be adding a call to PyErr_SetString. Sami> create_event_object on the other hand fails only due to failures in Sami> calls into the Python api. Which, presumably, do set errors. I don't remember :) But, I read this iteration of the patch and what you did is fine. Sami> +2011-01-21 Sami Wagiaalla Sami> + Oguz Kayral This is ok. Thanks for persevering, and congratulations. Tom