From: Tom Tromey <tromey@redhat.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [0/4] RFC: add DWARF index support
Date: Thu, 22 Jul 2010 15:54:00 -0000 [thread overview]
Message-ID: <m3y6d35x8p.fsf@fleche.redhat.com> (raw)
In-Reply-To: <m3fwzb7gfl.fsf@fleche.redhat.com> (Tom Tromey's message of "Thu, 22 Jul 2010 08:13:34 -0600")
>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:
Tom> The immediate problem is that a dwarf2_per_cu_data is embedded in struct
Tom> signatured_type, and initialized in create_debug_types_hash_table. This
Tom> embedded struct doesn't get its objfile member initialized.
Here is the fix for the immediate problem. It prevents gdb from dying.
I am checking this in. Bootstrapped & regtested on x86-64 (compile
farm), and also tested locally against an executable with .debug_types.
Tom> The bigger problem is that I completely forgot about .debug_types.
Tom> I am not certain that a simple fix will work if we have both
Tom> .debug_types and .gdb_index. I will try that out.
I think this is going to need an index version bump.
I am still looking into it.
Tom
2010-07-22 Tom Tromey <tromey@redhat.com>
* dwarf2read.c (create_debug_types_hash_table): Set objfile on
type signature's per-CU data.
Index: dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.421
diff -u -r1.421 dwarf2read.c
--- dwarf2read.c 21 Jul 2010 18:08:26 -0000 1.421
+++ dwarf2read.c 22 Jul 2010 15:42:38 -0000
@@ -2678,6 +2678,7 @@
type_sig->signature = signature;
type_sig->offset = offset;
type_sig->type_offset = type_offset;
+ type_sig->per_cu.objfile = objfile;
slot = htab_find_slot (types_htab, type_sig, INSERT);
gdb_assert (slot != NULL);
next prev parent reply other threads:[~2010-07-22 15:54 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 22:33 Tom Tromey
2010-07-09 17:31 ` Tom Tromey
2010-07-09 17:45 ` Eli Zaretskii
2010-07-09 20:26 ` Tom Tromey
2010-07-10 7:03 ` Eli Zaretskii
2010-07-12 16:52 ` Tom Tromey
2010-07-22 11:31 ` Jan Kratochvil
2010-07-22 15:54 ` Tom Tromey
2010-07-30 20:46 ` Tom Tromey
2010-08-02 18:10 ` Doug Evans
2010-08-05 16:30 ` Tom Tromey
2010-08-05 16:32 ` Doug Evans
2010-08-05 19:55 ` Tom Tromey
2010-08-05 19:57 ` Tom Tromey
2010-08-06 17:15 ` Doug Evans
2010-08-06 17:40 ` Tom Tromey
2010-08-06 20:53 ` Doug Evans
2010-08-09 20:36 ` Tom Tromey
2010-08-09 21:16 ` Doug Evans
2010-08-10 18:46 ` Tom Tromey
2010-08-10 18:57 ` Doug Evans
2010-08-09 20:25 ` Jan Kratochvil
2010-08-09 20:43 ` Tom Tromey
2010-08-09 20:33 ` Jan Kratochvil
2010-07-13 20:42 ` Tom Tromey
2010-07-22 4:28 ` Paul Pluzhnikov
2010-07-22 14:14 ` Tom Tromey
2010-07-22 15:54 ` Tom Tromey [this message]
2010-07-22 16:20 ` Paul Pluzhnikov
2010-07-22 20:54 ` Tom Tromey
2010-07-23 22:12 ` Tom Tromey
2010-07-26 18:41 ` Ken Werner
2010-07-26 18:50 ` Tom Tromey
2010-07-27 7:58 ` Ken Werner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3y6d35x8p.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=ppluzhnikov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).