From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87081 invoked by alias); 10 Aug 2015 18:06:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87065 invoked by uid 89); 10 Aug 2015 18:06:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f182.google.com Received: from mail-pd0-f182.google.com (HELO mail-pd0-f182.google.com) (209.85.192.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 10 Aug 2015 18:06:07 +0000 Received: by pdco4 with SMTP id o4so74048313pdc.3 for ; Mon, 10 Aug 2015 11:06:05 -0700 (PDT) X-Received: by 10.70.47.3 with SMTP id z3mr17268344pdm.120.1439229965891; Mon, 10 Aug 2015 11:06:05 -0700 (PDT) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by smtp.gmail.com with ESMTPSA id hv3sm6744445pbb.83.2015.08.10.11.06.04 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Aug 2015 11:06:05 -0700 (PDT) From: Doug Evans To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v6 5/9] Explicit locations: introduce probe locations References: <20150805232802.21646.88440.stgit@valrhona.uglyboxes.com> <20150805233007.21646.43939.stgit@valrhona.uglyboxes.com> Date: Mon, 10 Aug 2015 18:06:00 -0000 In-Reply-To: <20150805233007.21646.43939.stgit@valrhona.uglyboxes.com> (Keith Seitz's message of "Wed, 05 Aug 2015 16:30:20 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00223.txt.bz2 Keith Seitz writes: > * This patch has previously been approved. * > > This patch adds support for probe locations and converts existing > probe linespec locations to the new location type. > > gdb/ChangeLog: > > * break-catch-throw.c (re_set_exception_catchpoint): Convert > linespec for stap probe to probe location. > * breakpoint.c (create_longjmp_master_breakpoint) > (create_exception_master_breakpoint): Likewise. > (break_command_1): Remove local variable `arg_cp'. > Check location type to set appropriate breakpoint ops methods. > (trace_command): Likewise. > * linespec.c (event_location_to_sals): Assert on probe locations. > * location.c (EL_PROBE): Add macro definition. > (new_probe_location, get_probe_location): New functions. > (copy_event_location, delete_event_location, event_location_to_string) > (string_to_event_location, event_location_empty_p): Handle probe > locations. > * location.h (enum event_location_type): Add PROBE_LOCATION. > (new_probe_location, get_probe_location): Declare. > * probe.c (parse_probes): Assert that LOCATION is a probe location. > Convert linespec into probe location. Still approved.