From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75825 invoked by alias); 17 May 2015 20:10:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75805 invoked by uid 89); 17 May 2015 20:10:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f179.google.com Received: from mail-pd0-f179.google.com (HELO mail-pd0-f179.google.com) (209.85.192.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 17 May 2015 20:10:20 +0000 Received: by pdfh10 with SMTP id h10so117484665pdf.3 for ; Sun, 17 May 2015 13:10:18 -0700 (PDT) X-Received: by 10.70.129.106 with SMTP id nv10mr38650269pdb.160.1431893418180; Sun, 17 May 2015 13:10:18 -0700 (PDT) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by mx.google.com with ESMTPSA id mb4sm7841962pdb.63.2015.05.17.13.10.17 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 May 2015 13:10:17 -0700 (PDT) From: Doug Evans To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v4 1/9] Explicit locations: rename "address string"/"addr_string" to "location" References: <20150507180523.19629.77846.stgit@valrhona.uglyboxes.com> <20150507180546.19629.73286.stgit@valrhona.uglyboxes.com> Date: Sun, 17 May 2015 20:10:00 -0000 In-Reply-To: <20150507180546.19629.73286.stgit@valrhona.uglyboxes.com> (Keith Seitz's message of "Thu, 07 May 2015 11:05:46 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00447.txt.bz2 Keith Seitz writes: > This patch renames all occurrances of "addr_string" and "address > string" in the breakpoint/linespec APIs. This will emphasize the > change from address strings used in setting breakpoints (et al) to the > new locations-based API introduced in subsequent patches. > > gdb/ChangeLog: > > * breakpoint.h (struct breakpoint_ops) : > Renamed to create_sals_from_location. > : Renamed to decode_location. > Update all callers. > * breakpoint.c (create_sals_from_address_default): Renamed to ... > (create_sals_from_location_default): ... this. > (addr_string_to_sals): Renamed to ... > (location_to_sals): ... this. > (decode_linespec_default): Renamed to ... > (decode_location_default): ... this. > (base_breakpoint_create_sals_from_address): Renamed to ... > (base_breakpoint_create_sals_from_location): ... this. > (bkpt_create_sals_from_address): Renamed to ... > (bkpt_create_sals_from_location): ... this. > (bkpt_decode_linespec): Renamed to ... > (bkpt_decode_location): ... this. > (bkpt_probe_create_sals_from_address): Renamed to ... > (bkpt_probe_create_sals_from_location): ... this. > (tracepoint_create_sals_from_address): Renamed to ... > (tracepoint_create_sals_from_location): ... this. > (tracepoint_decode_linespec): Renamed to ... > (tracepoint_decode_location): ... this. > (tracepoint_probe_create_sals_from_address): Renamed to ... > (tracepoint_probe_create_sals_from_location): ... this. > (tracepoint_probe_decode_linespec): Renamed to ... > (tracepoint_probe_decode_location): ... this. > (strace_marker_create_sals_from_address): Renamed to ... > (strace_marker_create_sals_from_location): ... this. > (decode_linespec_default): Renamed to ... > (decode_location_default): ... this. LGTM