From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31954 invoked by alias); 22 Jun 2014 22:17:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31941 invoked by uid 89); 22 Jun 2014 22:17:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 22 Jun 2014 22:17:24 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5MMHKrw024709 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 22 Jun 2014 18:17:20 -0400 Received: from psique (ovpn-113-28.phx2.redhat.com [10.3.113.28]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5MMHG4n003095 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sun, 22 Jun 2014 18:17:18 -0400 From: Sergio Durigan Junior To: Jan Kratochvil Cc: Mark Kettenis , gdb-patches@sourceware.org, brobecker@adacore.com Subject: Re: [testsuite patch+7.8] gdb.arch/amd64-stap-special-operands.exp !is_lp64_target [Re: [PATCH] Fix for PR tdep/16397: SystemTap SDT probe support for x86 doesn't work with "triplet operands"] References: <201401301535.s0UFZp3N013895@glazunov.sibelius.xs4all.nl> <20140622211401.GA3716@host2.jankratochvil.net> X-URL: http://www.redhat.com Date: Sun, 22 Jun 2014 22:17:00 -0000 In-Reply-To: <20140622211401.GA3716@host2.jankratochvil.net> (Jan Kratochvil's message of "Sun, 22 Jun 2014 23:14:01 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00799.txt.bz2 On Sunday, June 22 2014, Jan Kratochvil wrote: > On Thu, 20 Feb 2014 22:53:21 +0100, Sergio Durigan Junior wrote: >> Thanks, I finally pushed it with the necessary fixes. >> https://sourceware.org/ml/gdb-cvs/2014-02/msg00106.html > # if { ![istarget "x86_64-*-*"] && ![istarget "i?86-*-*"] } { > # verbose "Skipping amd64-stap-special-operands.exp" > # return > # } > > On x86_64 with -m32 or on i686 it will: > > Running ./gdb.arch/amd64-stap-special-operands.exp ... > gdb compile failed, amd64-stap-triplet.c: Assembler messages: > amd64-stap-triplet.c:35: Error: bad register name `%rbp' > amd64-stap-triplet.c:38: Error: bad register name `%rsp' > amd64-stap-triplet.c:40: Error: bad register name `%rbp)' > amd64-stap-triplet.c:41: Error: bad register name `%rsi' > amd64-stap-triplet.c:42: Error: bad register name `%rbp)' > /tmp/ccjOdmpl.s:63: Error: bad register name `%rbp' > > IMO there should be the patch below. OK for check-in? > It would apply as [obv] but I rather ask Sergio if it was meant this way. Ops, my bad. > Jan > gdb/testsuite/ > 2014-06-22 Jan Kratochvil > > * gdb.arch/amd64-stap-special-operands.exp: Use is_lp64_target. > > diff --git a/gdb/testsuite/gdb.arch/amd64-stap-special-operands.exp b/gdb/testsuite/gdb.arch/amd64-stap-special-operands.exp > index a6ce7f5..988b5d6 100644 > --- a/gdb/testsuite/gdb.arch/amd64-stap-special-operands.exp > +++ b/gdb/testsuite/gdb.arch/amd64-stap-special-operands.exp > @@ -13,7 +13,7 @@ > # You should have received a copy of the GNU General Public License > # along with this program. If not, see . > > -if { ![istarget "x86_64-*-*"] && ![istarget "i?86-*-*"] } { > +if { ![istarget "x86_64-*-*"] || ![is_lp64_target] } { > verbose "Skipping amd64-stap-special-operands.exp" > return > } Yes, that's the right check. BTW, gdb.arch/amd64-stap-optional-prefix.exp needs the same check for ![is_lp64_target], would you mind adding too? Thanks, -- Sergio GPG key ID: 65FC5E36 Please send encrypted e-mail if possible http://blog.sergiodj.net/