From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>,
Pedro Alves <pedro@codesourcery.com>,
Tristan Gingold <gingold@adacore.com>,
"gdb-patches\@sourceware.org ml"
<gdb-patches@sourceware.org>
Subject: Re: [RFA] make first parameter of to_lookup_symbol const char *
Date: Wed, 16 Mar 2011 15:03:00 -0000 [thread overview]
Message-ID: <m3zkov5dsb.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20110316135810.GA6590@adacore.com> (Joel Brobecker's message of "Wed, 16 Mar 2011 06:58:10 -0700")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> This is what it looks like to remove the target_ops method. It feels
Joel> a little like excising a potentially useful feature, so I'm not going
Joel> to commit without review, although there is no sign that we'll ever
Joel> need it any time soon. But I added a comment explaining what we used
Joel> to do, to give us a clue later on, if we encounter a target where
Joel> we might need something of this kind.
I think it is a good idea to remove unused code. If it is needed in the
future, it is simple enough to resurrect or rewrite this code.
The patch looks fine to me.
Tom
next prev parent reply other threads:[~2011-03-16 14:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 11:56 Tristan Gingold
2011-03-14 13:53 ` Jan Kratochvil
2011-03-16 14:02 ` Joel Brobecker
2011-03-16 15:03 ` Tom Tromey [this message]
2011-03-16 20:03 ` Stan Shebs
2011-03-17 14:58 ` Joel Brobecker
2011-03-14 14:03 ` Pedro Alves
2011-03-14 14:21 ` Tristan Gingold
2011-03-15 8:26 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3zkov5dsb.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=gingold@adacore.com \
--cc=jan.kratochvil@redhat.com \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).