From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28822 invoked by alias); 16 Mar 2011 14:41:22 -0000 Received: (qmail 28813 invoked by uid 22791); 16 Mar 2011 14:41:21 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 Mar 2011 14:41:13 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2GEesb9019804 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 16 Mar 2011 10:40:54 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p2GEernP026006; Wed, 16 Mar 2011 10:40:54 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p2GEerJd022162; Wed, 16 Mar 2011 10:40:53 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id C081AC8847A; Wed, 16 Mar 2011 08:40:52 -0600 (MDT) From: Tom Tromey To: Joel Brobecker Cc: Jan Kratochvil , Pedro Alves , Tristan Gingold , "gdb-patches\@sourceware.org ml" Subject: Re: [RFA] make first parameter of to_lookup_symbol const char * References: <58CFFAD9-1C02-4AD8-B416-FC48D1A7F006@adacore.com> <20110314134616.GA2680@host1.jankratochvil.net> <20110316135810.GA6590@adacore.com> Date: Wed, 16 Mar 2011 15:03:00 -0000 In-Reply-To: <20110316135810.GA6590@adacore.com> (Joel Brobecker's message of "Wed, 16 Mar 2011 06:58:10 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00847.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> This is what it looks like to remove the target_ops method. It feels Joel> a little like excising a potentially useful feature, so I'm not going Joel> to commit without review, although there is no sign that we'll ever Joel> need it any time soon. But I added a comment explaining what we used Joel> to do, to give us a clue later on, if we encounter a target where Joel> we might need something of this kind. I think it is a good idea to remove unused code. If it is needed in the future, it is simple enough to resurrect or rewrite this code. The patch looks fine to me. Tom