From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-76292-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3951 invoked by alias); 2 Nov 2010 20:31:16 -0000
Received: (qmail 3942 invoked by uid 22791); 2 Nov 2010 20:31:15 -0000
X-SWARE-Spam-Status: No, hits=-6.2 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 02 Nov 2010 20:31:08 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oA2KV7db011825	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Tue, 2 Nov 2010 16:31:07 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oA2KV6fa016880;	Tue, 2 Nov 2010 16:31:06 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id oA2KV6tB009421;	Tue, 2 Nov 2010 16:31:06 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id 2FC90C88041; Tue,  2 Nov 2010 12:29:18 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: sami wagiaalla <swagiaal@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 1/2] Overload resolution among children of a common ancestor
References: <4C7BD80C.1050906@redhat.com> <4CBDFF43.7000403@redhat.com>	<m3wrpadyhk.fsf@fleche.redhat.com> <4CD052B0.40906@redhat.com>
Date: Tue, 02 Nov 2010 20:31:00 -0000
In-Reply-To: <4CD052B0.40906@redhat.com> (sami wagiaalla's message of "Tue, 02	Nov 2010 14:04:32 -0400")
Message-ID: <m3zktrh94y.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-11/txt/msg00049.txt.bz2

>>>>> "Sami" == sami wagiaalla <swagiaal@redhat.com> writes:

Sami> Hmm.. is it cool if I just declare the constants 'extern const' in the
Sami> header and then define them in gdbtypes.c, without #defines ? As in
Sami> the attached patch.

Yeah, that is fine.  It is a little weird to have uppercased names, but
I think it is fine in this case.

This patch is ok.  Thanks.

Tom