From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15320 invoked by alias); 7 Oct 2010 08:01:28 -0000 Received: (qmail 15298 invoked by uid 22791); 7 Oct 2010 08:01:26 -0000 X-SWARE-Spam-Status: No, hits=-5.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Oct 2010 08:01:21 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o978159k000965 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 7 Oct 2010 04:01:05 -0400 Received: from localhost.localdomain.redhat.com (ovpn-113-60.phx2.redhat.com [10.3.113.60]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o97812x4001567; Thu, 7 Oct 2010 04:01:03 -0400 From: Phil Muldoon To: Joel Brobecker Cc: Doug Evans , gdb-patches@sourceware.org Subject: Re: Python coding style [was Re: [RFA] New python module gdb.types] References: <4CACEBEA.1080900@redhat.com> <20101006222337.GC2784@adacore.com> Reply-to: pmuldoon@redhat.com X-URL: http://www.redhat.com Date: Thu, 07 Oct 2010 08:01:00 -0000 In-Reply-To: <20101006222337.GC2784@adacore.com> (Joel Brobecker's message of "Wed, 6 Oct 2010 15:23:37 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00117.txt.bz2 Joel Brobecker writes: >> My deeply biased and very personal ideology her e is if how emacs >> handles it. > > I think it would be wrong to adopt that philosophy, and to be honest, > I'm getting a little tired about having to suffer certain decisions > purely because this is the default emacs indentation style. Well I did preface my comments with heavy disclaimers ;) But I wasn't aware this was such a controversial choice or that hackers had to suffer for it. FWIW I find the GNU C style somewhat hard to grok even now, after years and using Emacs pretty consistently (with various forays to Eclipse). Anyway, I did not want to drag out history into the conversation (unintentionally or not). > I just think it's more important to be consistent > with the rest of the Python community. > > There is actually an official Python Coding Style, called PEP8: > > http://www.python.org/dev/peps/pep-0008/ That's great. Good to see. > I think we should strive to not break whatever suggestions this guide > provides, and add some extra of our own if we feel necessary. And I'll disagree here ;) I think if we are striving to be consistent with the community, adding a little of our own sauce should be a question we should examine at least briefly. What I've read of the PEP seems pretty comprehensive. > I looked at the Google Python Style Guide, and it does not conflict > with PEP8. I also have relatively limited knowledge of Python, but > I absolutely agree with everything in that document. See above. My own opinion is that we should purely not opt for one particular flavor because there exists a vacuum. Why not follow the PEP to the letter? The Google guide looks sane, and really nice. But what are the strong feelings the project should add this particular sauce over the PEP? I just want to briefly examine those questions. Finally I'll argue against my own point and note that Tom has mentioned this will all work with Emacs anyway. Maybe I am building a huge straw-man. But this is something that worries me a little bit. Once a standard is adopted (in particular a coding standard), it's usually there forever. Cheers, Phil