From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17745 invoked by alias); 4 Jun 2010 22:37:36 -0000 Received: (qmail 17735 invoked by uid 22791); 4 Jun 2010 22:37:35 -0000 X-SWARE-Spam-Status: No, hits=-5.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Jun 2010 22:37:28 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o54MbRBD004578 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 4 Jun 2010 18:37:27 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o54MbNZS013690; Fri, 4 Jun 2010 18:37:23 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o54MbMQx010980; Fri, 4 Jun 2010 18:37:22 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id F0C0437897F; Fri, 4 Jun 2010 16:37:21 -0600 (MDT) From: Tom Tromey To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Delayed physname computation References: <4BCE0D3C.7040201@redhat.com> <4BD22E6A.9020309@redhat.com> <4BE9C9A0.2030605@redhat.com> Reply-To: tromey@redhat.com Date: Fri, 04 Jun 2010 22:37:00 -0000 In-Reply-To: <4BE9C9A0.2030605@redhat.com> (Keith Seitz's message of "Tue, 11 May 2010 14:18:24 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00148.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> If you put a printf in set_die_type, you'll see that this function is Keith> called twice (with different type structs) for the same DIE. This part seems quite weird to me. But maybe the only real fix for it would be two passes over the DIEs, or something equally horrible. Keith> Since there is no way to detect/trigger this in gdb without the Keith> delayed physname patch, there seems little point IMO in testing Keith> specifically for this. However it would be trivial for me to write up Keith> a testcase for this. Just say the word. I think a test case for this would be good, just to prevent regressions in the case where someone tries to remove code that looks weird to them. Both of these patches are ok. Thanks, and sorry for the delay in reviewing them. Keith> + physname = (char *) dwarf2_physname ((char *) mi->name, mi->die, cu); It would be nice to const-correct enough so that we could remove these casts. I'm not asking you to do it though :-) Tom