Re: [PATCH 1/2] RISC-V GDB Port

[Palmer Dabbelt <palmer@dabbelt.com>]

On Tue, 04 Apr 2017 14:48:24 PDT (-0700), qiyaoltc@gmail.com wrote:
> Palmer Dabbelt <palmer@dabbelt.com> writes:
>
> Hi,
> I have some time today, so I can review the patch.
>
>>  gdb/Makefile.in                 |    5 +
>>  gdb/config/riscv/linux.mh       |   30 +
>>  gdb/features/Makefile           |    2 +
>>  gdb/features/riscv.c            |   86 +++
>>  gdb/features/riscv.xml          |   81 +++
>>  gdb/gdbserver/linux-riscv-low.c |  221 +++++++
>>  gdb/regformats/riscv.dat        |   69 ++
>>  gdb/riscv-linux-nat.c           |   77 +++
>>  gdb/riscv-linux-tdep.c          |   80 +++
>>  gdb/riscv-linux-tdep.h          |   30 +
>>  gdb/riscv-tdep.c                | 1368 +++++++++++++++++++++++++++++++++++++++
>>  gdb/riscv-tdep.h                |   96 +++
>>  include/gdb/sim-riscv.h         |   98 +++
>
> Before I read the patch further, my suggestion is to split your patch
> to following parts next time,
>
>  - bare metal support, riscv-tdep.c
>  - linux target support, riscv-linux-tdep.c,
>  - linux host support, riscv-linux-nat.c,
>  - gdbserver support, gdbserver/linux-riscv-low.c
>  - target description,

Thanks for all the time you've spent on this, I'll try to get the port in
better shape.

> I am surprised that there is no change to gdb/testsuite/.

We've generally not tested things well, I'll have some tests for the next
round.