From: Palmer Dabbelt <palmer@dabbelt.com>
To: tom@tromey.com
Cc: tangyouling@loongson.cn, gdb-patches@sourceware.org, macro@orcam.me.uk
Subject: Re: [PATCH] gdbserver: Remove srv_linux_usrregs setting in RISCV
Date: Fri, 13 May 2022 09:32:23 -0700 (PDT) [thread overview]
Message-ID: <mhng-c0bef111-588e-4a88-9c7b-5b84abfd8ada@palmer-ri-x1c9> (raw)
In-Reply-To: <87tu9yiydt.fsf@tromey.com>
On Mon, 09 May 2022 07:17:18 PDT (-0700), tom@tromey.com wrote:
>>>>>> Youling Tang <tangyouling@loongson.cn> writes:
>
>> In the linux kernel code of RISCV, ptrace does not have the implementation
>> of PTRACE_POKEUSR/PTRACE_PEEKUSR in the arch_ptrace function (like aarch64),
>> If srv_linux_usrregs is set to yes, HAVE_LINUX_USRREGS will be defined, so
>> remove the srv_linux_usrregs setting.
>
> Looks reasonable to me.
For some reason Maciej's email is only showing up in my gmail, so I'm
just pasting in
> Yeah, it must have been an oversight. Thanks for the fix!
IIRC we had some out-of-tree ptrace() implementations that were to the
old style, but they never made it upstream. I bet the GDB support just
stuck around, but I don't see a reason to keep it.
prev parent reply other threads:[~2022-05-13 16:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 12:39 Youling Tang
2022-05-09 14:17 ` Tom Tromey
2022-05-09 14:44 ` Maciej W. Rozycki
2022-05-13 16:32 ` Palmer Dabbelt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-c0bef111-588e-4a88-9c7b-5b84abfd8ada@palmer-ri-x1c9 \
--to=palmer@dabbelt.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@orcam.me.uk \
--cc=tangyouling@loongson.cn \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).