From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id AD276383D82E for ; Fri, 13 May 2022 16:32:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AD276383D82E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dabbelt.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dabbelt.com Received: by mail-pg1-x532.google.com with SMTP id g184so7989381pgc.1 for ; Fri, 13 May 2022 09:32:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20210112.gappssmtp.com; s=20210112; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version :content-transfer-encoding; bh=+XYZ71MqPGchYxCWYMemxOeklBN8Vc1OXNFO2LvpYhU=; b=2Dx5HgB+8pKnTmH/tBfFH3WnZSn8jg7FZFBwM1pftpuEvWXjHkEWQAFMeVFvg9xvWD v2aAF5Ayl+RF3yM4HiDWWsaMuGrZd8zq3r9FtjAE3iWbQI7arXFThNBEO2437BNRogca dKapAonwpohUmWKxvs0TqxwuKV2/ayYLupxJboxE4BJbwA/FDDpB5Lo7hqQPd7yxs7Th fQvSZGcup4wmOfAcOL81F+i5wYXCGsOsjyxsaHTygc1hZ9ulXJ8rO1UyNjxX/E6BE0kG vu3QiL6zYEDVmTDJWuuw4qigOrE/1Qv7r7T/eF6m0YFh3TcLLTJjms4MN9QCaCNeO0xp j9uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=+XYZ71MqPGchYxCWYMemxOeklBN8Vc1OXNFO2LvpYhU=; b=OyBbOn0MLq0O1no3gsw6WFDukoZgLfchGN18xKEGJhrun04qAsFZv16kx3r+P445C9 OHxy53DLm4YlpMnc3Rc49owJjI8LL47OITYWJZNvb0XcEXga1EpoYfdTkUmFaOiFwpuy d4h1SOuLx6c8NoEG4h+BlFH3jwgBirIJkTO+vQgZW3DUxI0w6YBNgiyg/Uyk2ICfuP56 IkyXA6DagJ4jKsyHeHXrNHg3q9zVHrlJ1eB3358RYCltWqAzRJk7cnqzl0tlXgeP++Gw Zv3F3tFFtdhxlZirmQTUZNGc+V9c3l7QtaKKuKOuLLCbIkKfEHHdZWYysr+Rg1KPDbkw S+Pw== X-Gm-Message-State: AOAM530OnHJfCkaUODl0sFTXAmFc9Oe80nfJKRqZ3wH8SfnL/cTj4cHa c1iCZi78qS8/J7TiF+zN5MD0oE2lfqE80g== X-Google-Smtp-Source: ABdhPJywdqaA57n1VMCrNGXByTPNnWOy/wzQse6Hm3Vovfa+YYeIl7ZijBzl0kwP47GbLN86g3rV6Q== X-Received: by 2002:a63:4e62:0:b0:398:cb40:19b0 with SMTP id o34-20020a634e62000000b00398cb4019b0mr4647653pgl.445.1652459543519; Fri, 13 May 2022 09:32:23 -0700 (PDT) Received: from localhost ([2607:fb91:792d:f71d:c212:e279:d579:e41c]) by smtp.gmail.com with ESMTPSA id p1-20020aa78601000000b00512ee8a74a9sm292456pfn.217.2022.05.13.09.32.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 09:32:23 -0700 (PDT) Date: Fri, 13 May 2022 09:32:23 -0700 (PDT) X-Google-Original-Date: Fri, 13 May 2022 09:32:17 PDT (-0700) Subject: Re: [PATCH] gdbserver: Remove srv_linux_usrregs setting in RISCV In-Reply-To: <87tu9yiydt.fsf@tromey.com> CC: tangyouling@loongson.cn, gdb-patches@sourceware.org, macro@orcam.me.uk From: Palmer Dabbelt To: tom@tromey.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2022 16:32:26 -0000 On Mon, 09 May 2022 07:17:18 PDT (-0700), tom@tromey.com wrote: >>>>>> Youling Tang writes: > >> In the linux kernel code of RISCV, ptrace does not have the implementation >> of PTRACE_POKEUSR/PTRACE_PEEKUSR in the arch_ptrace function (like aarch64), >> If srv_linux_usrregs is set to yes, HAVE_LINUX_USRREGS will be defined, so >> remove the srv_linux_usrregs setting. > > Looks reasonable to me. For some reason Maciej's email is only showing up in my gmail, so I'm just pasting in > Yeah, it must have been an oversight. Thanks for the fix! IIRC we had some out-of-tree ptrace() implementations that were to the old style, but they never made it upstream. I bet the GDB support just stuck around, but I don't see a reason to keep it.