From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <schwab@suse.de>
Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c])
 by sourceware.org (Postfix) with ESMTPS id 1F80C3858D1E;
 Tue,  4 Oct 2022 09:04:47 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1F80C3858D1E
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
 by smtp-out1.suse.de (Postfix) with ESMTP id 429EC219BF;
 Tue,  4 Oct 2022 09:04:46 +0000 (UTC)
Received: from hawking.suse.de (unknown [10.168.4.11])
 by relay2.suse.de (Postfix) with ESMTP id E3A662C146;
 Tue,  4 Oct 2022 09:04:45 +0000 (UTC)
Received: by hawking.suse.de (Postfix, from userid 17005)
 id A72564401E9; Tue,  4 Oct 2022 11:04:45 +0200 (CEST)
From: Andreas Schwab <schwab@suse.de>
To: Tsukasa OI via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tsukasa OI <research_trasio@irq.a4lg.com>,  Nelson Chu
 <nelson@rivosinc.com>,  Kito Cheng <kito.cheng@sifive.com>,  Palmer
 Dabbelt <palmer@dabbelt.com>,  Andrew Burgess <aburgess@redhat.com>,  Jan
 Beulich <jbeulich@suse.com>,  binutils@sourceware.org
Subject: Re: [PATCH 2/2] gdb/riscv: Fix buffer overflow on
 riscv_insn::fetch_instruction
References: <cover.1664873933.git.research_trasio@irq.a4lg.com>
 <89612fe01d902007bf84a7dfb0df5f85d5c166e4.1664873933.git.research_trasio@irq.a4lg.com>
X-Yow: I'm a GENIUS! I want to dispute sentence structure with SUSAN SONTAG!!
Date: Tue, 04 Oct 2022 11:04:45 +0200
In-Reply-To: <89612fe01d902007bf84a7dfb0df5f85d5c166e4.1664873933.git.research_trasio@irq.a4lg.com>
 (Tsukasa OI via Gdb-patches's message of "Tue, 4 Oct 2022 08:59:08
 +0000")
Message-ID: <mvm1qrohscy.fsf@suse.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Oct 2022 09:04:49 -0000

On Okt 04 2022, Tsukasa OI via Gdb-patches wrote:

> diff --git a/gdb/riscv-tdep.c b/gdb/riscv-tdep.c
> index 47d8f9e601b..99307bd2de1 100644
> --- a/gdb/riscv-tdep.c
> +++ b/gdb/riscv-tdep.c
> @@ -1770,7 +1770,7 @@ riscv_insn::fetch_instruction (struct gdbarch *gdbarch,
>  			       CORE_ADDR addr, int *len)
>  {
>    enum bfd_endian byte_order = gdbarch_byte_order_for_code (gdbarch);
> -  gdb_byte buf[8];
> +  gdb_byte buf[22];

Can the magic number be derived from something else so that is adapts
automatically?

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."