From: Andreas Schwab <schwab@suse.de>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [committed][gdb/testsuite] Fix core file load FAIL in tls-core.exp
Date: Thu, 12 Mar 2020 10:20:00 +0100 [thread overview]
Message-ID: <mvm7dzq53r3.fsf@suse.de> (raw)
In-Reply-To: <20200312085140.GA32141@delia> (Tom de Vries's message of "Thu, 12 Mar 2020 09:51:44 +0100")
On Mär 12 2020, Tom de Vries wrote:
> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
> index 9e903ba347..bb70ef13f2 100644
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
> @@ -4648,7 +4648,7 @@ proc gdb_core_cmd { core test } {
> fail "$test (bad file format)"
> return -1
> }
> - -re ": No such file or directory.*\r\n$gdb_prompt $" {
> + -re "$core: No such file or directory.*\r\n$gdb_prompt $" {
I think you need to regexp-quote the string.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2020-03-12 9:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 8:51 Tom de Vries
2020-03-12 9:20 ` Andreas Schwab [this message]
2020-03-12 10:04 ` [committed][gdb/testsuite] Use string_to_regexp on core filename in gdb_core_cmd Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvm7dzq53r3.fsf@suse.de \
--to=schwab@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).