From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id CE1853943550 for ; Thu, 12 Mar 2020 09:20:01 +0000 (GMT) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 8FD7AAC26 for ; Thu, 12 Mar 2020 09:20:00 +0000 (UTC) From: Andreas Schwab To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [committed][gdb/testsuite] Fix core file load FAIL in tls-core.exp References: <20200312085140.GA32141@delia> X-Yow: You can't hurt me!! I have an ASSUMABLE MORTGAGE!! Date: Thu, 12 Mar 2020 10:20:00 +0100 In-Reply-To: <20200312085140.GA32141@delia> (Tom de Vries's message of "Thu, 12 Mar 2020 09:51:44 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Mar 2020 09:20:02 -0000 On Mär 12 2020, Tom de Vries wrote: > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index 9e903ba347..bb70ef13f2 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -4648,7 +4648,7 @@ proc gdb_core_cmd { core test } { > fail "$test (bad file format)" > return -1 > } > - -re ": No such file or directory.*\r\n$gdb_prompt $" { > + -re "$core: No such file or directory.*\r\n$gdb_prompt $" { I think you need to regexp-quote the string. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."