From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114621 invoked by alias); 1 Sep 2016 08:32:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114603 invoked by uid 89); 1 Sep 2016 08:32:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Sep 2016 08:32:09 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 88F8FAAF1; Thu, 1 Sep 2016 08:32:06 +0000 (UTC) From: Andreas Schwab To: Andrew Pinski Cc: gdb-patches@sourceware.org, binutils@sourceware.org Subject: Re: [PATCH 3/3] Handle ILP32 AARCH64 correctly for gdbserver References: <1472516750-30743-1-git-send-email-apinski@cavium.com> <1472715400-43043-1-git-send-email-apinski@cavium.com> <1472715400-43043-4-git-send-email-apinski@cavium.com> X-Yow: Hiccuping & trembling into the WASTE DUMPS of New Jersey like some drunken CABBAGE PATCH DOLL, coughing in line at FIORUCCI'S!! Date: Thu, 01 Sep 2016 08:32:00 -0000 In-Reply-To: <1472715400-43043-4-git-send-email-apinski@cavium.com> (Andrew Pinski's message of "Thu, 1 Sep 2016 00:36:40 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2016-09/txt/msg00007.txt.bz2 On Sep 01 2016, Andrew Pinski wrote: > diff --git a/gdb/gdbserver/linux-aarch64-ipa.c b/gdb/gdbserver/linux-aarch64-ipa.c > index 601d61c..d713bfa 100644 > --- a/gdb/gdbserver/linux-aarch64-ipa.c > +++ b/gdb/gdbserver/linux-aarch64-ipa.c > @@ -29,6 +29,9 @@ > /* Defined in auto-generated file aarch64.c. */ > void init_registers_aarch64 (void); > extern const struct target_desc *tdesc_aarch64; > +/* Defined in auto-geenrated file aarch64_ilp32.c. */ generated > @@ -155,6 +158,9 @@ get_raw_reg (const unsigned char *raw_regs, int regnum) > const struct target_desc * > get_ipa_tdesc (int idx) > { > + if (sizeof (void*) == 4) Space before *. > @@ -207,5 +213,8 @@ alloc_jump_pad_buffer (size_t size) > void > initialize_low_tracepoint (void) > { > - init_registers_aarch64 (); > + if (sizeof(void*) == 4) Space before ( and *. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."